p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

staging: unisys: visorbus: keep the success path on the left 

The code was indenting for the successful path and then combining the
error and success path for the rest of the function. Correct it so the
success path is not indented.

Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Tim Sell <timothy.sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
David Kershner 2017-09-27 13:14:20 -04:00 committed by Greg Kroah-Hartman
parent 5d1a7fd754
commit 61f38f9a42
1 changed files with 9 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
drivers/staging/unisys/visorbus/visorbus_main.c
View File

@ -888,7 +888,7 @@ static void publish_vbus_dev_info(struct visor_device *visordev)
*/
static int visordriver_probe_device(struct device *xdev)
{
int res;
int err;
struct visor_driver *drv;
struct visor_device *dev;
@ -898,15 +898,17 @@ static int visordriver_probe_device(struct device *xdev)
mutex_lock(&dev->visordriver_callback_lock);
dev->being_removed = false;
res = drv->probe(dev);
if (res >= 0) {
/* success: reference kept via unmatched get_device() */
get_device(&dev->device);
publish_vbus_dev_info(dev);
err = drv->probe(dev);
if (err) {
mutex_unlock(&dev->visordriver_callback_lock);
return err;
}
/* success: reference kept via unmatched get_device() */
get_device(&dev->device);
publish_vbus_dev_info(dev);
mutex_unlock(&dev->visordriver_callback_lock);
return res;
return 0;
}
/*