p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Smack: Use memdup_user() rather than duplicating its implementation 

Reuse existing functionality from memdup_user() instead of keeping
duplicate source code.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Acked-by: Casey Schaufler <casey@schaufler-ca.com>
This commit is contained in:
Markus Elfring 2016-08-21 20:17:36 +02:00 committed by Casey Schaufler
parent 29b4817d40
commit 63e24c4971
1 changed files with 3 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
security/smack/smackfs.c
View File

@ -2523,14 +2523,9 @@ static ssize_t smk_write_revoke_subj(struct file *file, const char __user *buf,
if (count == 0 || count > SMK_LONGLABEL) if (count == 0 || count > SMK_LONGLABEL)
return -EINVAL; return -EINVAL;
data = kzalloc(count, GFP_KERNEL); data = memdup_user(buf, count);
if (data == NULL) if (IS_ERR(data))
return -ENOMEM; return PTR_ERR(data);
if (copy_from_user(data, buf, count) != 0) {
rc = -EFAULT;
goto out_data;
}
cp = smk_parse_smack(data, count); cp = smk_parse_smack(data, count);
if (IS_ERR(cp)) { if (IS_ERR(cp)) {