p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

perf values: Fix thread index bug 

We are taking wrong index (+1) for first thread, which leaves thread
with index 0 unused and uninitialized.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/20170824162737.7813-7-jolsa@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:
Jiri Olsa 2017-08-24 18:27:33 +02:00 committed by Arnaldo Carvalho de Melo
parent dac7f6b7ed
commit 64eed1deb6
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tools/perf/util/values.c
View File

@ -98,7 +98,7 @@ static int perf_read_values__findnew_thread(struct perf_read_values *values,
return i; return i;
} }
i = values->threads + 1; i = values->threads;
values->value[i] = malloc(values->counters_max * sizeof(**values->value)); values->value[i] = malloc(values->counters_max * sizeof(**values->value));
if (!values->value[i]) { if (!values->value[i]) {
pr_debug("failed to allocate read_values counters array"); pr_debug("failed to allocate read_values counters array");
@ -106,7 +106,7 @@ static int perf_read_values__findnew_thread(struct perf_read_values *values,
} }
values->pid[i] = pid; values->pid[i] = pid;
values->tid[i] = tid; values->tid[i] = tid;
values->threads = i; values->threads = i + 1;
return i; return i;
} }