p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

media: staging: atomisp: fix string comparation logic 

it makes no sense to use strncmp() with a size with is
bigger than the string we're comparing with.

Fix those warnings:

    drivers/staging/media/atomisp/pci/atomisp2/atomisp_fops.c:776 atomisp_open() error: strncmp() '"ATOMISP ISP ACC"' too small (16 vs 32)
    drivers/staging/media/atomisp/pci/atomisp2/atomisp_fops.c:913 atomisp_release() error: strncmp() '"ATOMISP ISP ACC"' too small (16 vs 32)
    drivers/staging/media/atomisp/pci/atomisp2/atomisp_ioctl.c:2751 atomisp_vidioc_default() error: strncmp() '"ATOMISP ISP ACC"' too small (16 vs 32)

Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
This commit is contained in:
Mauro Carvalho Chehab 2018-04-06 14:45:59 -04:00
parent 90d53d199a
commit 65c1167373
2 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/staging/media/atomisp/pci/atomisp2/atomisp_fops.c
View File

@ -773,8 +773,7 @@ static int atomisp_open(struct file *file)
rt_mutex_lock(&isp->mutex);
acc_node = !strncmp(vdev->name, "ATOMISP ISP ACC",
sizeof(vdev->name));
acc_node = !strcmp(vdev->name, "ATOMISP ISP ACC");
if (acc_node) {
acc_pipe = atomisp_to_acc_pipe(vdev);
asd = acc_pipe->asd;
@ -910,8 +909,7 @@ static int atomisp_release(struct file *file)
rt_mutex_lock(&isp->mutex);
dev_dbg(isp->dev, "release device %s\n", vdev->name);
acc_node = !strncmp(vdev->name, "ATOMISP ISP ACC",
sizeof(vdev->name));
acc_node = !strcmp(vdev->name, "ATOMISP ISP ACC");
if (acc_node) {
acc_pipe = atomisp_to_acc_pipe(vdev);
asd = acc_pipe->asd;

3
drivers/staging/media/atomisp/pci/atomisp2/atomisp_ioctl.c
View File

@ -2748,8 +2748,7 @@ static long atomisp_vidioc_default(struct file *file, void *fh,
bool acc_node;
int err;
acc_node = !strncmp(vdev->name, "ATOMISP ISP ACC",
sizeof(vdev->name));
acc_node = !strcmp(vdev->name, "ATOMISP ISP ACC");
if (acc_node)
asd = atomisp_to_acc_pipe(vdev)->asd;
else