p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

drm: stm: remove dead code and pointless local lut storage 

The redundant fb helper .load_lut is no longer used, and can not
work right without also providing the fb helpers .gamma_set and
.gamma_get thus rendering the code in this driver suspect.

Just remove the dead code.

Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Peter Rosin <peda@axentia.se>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20170713162538.22788-14-peda@axentia.se
This commit is contained in:
Peter Rosin 2017-07-13 18:25:37 +02:00 committed by Daniel Vetter
parent 42585395eb
commit 65c6680d38
2 changed files with 0 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/gpu/drm/stm/ltdc.c
View File

@ -362,17 +362,6 @@ static irqreturn_t ltdc_irq(int irq, void *arg)
* DRM_CRTC * DRM_CRTC
*/ */
static void ltdc_crtc_load_lut(struct drm_crtc *crtc)
{
struct ltdc_device *ldev = crtc_to_ltdc(crtc);
unsigned int i, lay;
for (lay = 0; lay < ldev->caps.nb_layers; lay++)
for (i = 0; i < 256; i++)
reg_write(ldev->regs, LTDC_L1CLUTWR + lay * LAY_OFS,
ldev->clut[i]);
}
static void ltdc_crtc_atomic_enable(struct drm_crtc *crtc, static void ltdc_crtc_atomic_enable(struct drm_crtc *crtc,
struct drm_crtc_state *old_state) struct drm_crtc_state *old_state)
{ {
@ -512,7 +501,6 @@ static void ltdc_crtc_atomic_flush(struct drm_crtc *crtc,
} }
static const struct drm_crtc_helper_funcs ltdc_crtc_helper_funcs = { static const struct drm_crtc_helper_funcs ltdc_crtc_helper_funcs = {
.load_lut = ltdc_crtc_load_lut,
.mode_set_nofb = ltdc_crtc_mode_set_nofb, .mode_set_nofb = ltdc_crtc_mode_set_nofb,
.atomic_flush = ltdc_crtc_atomic_flush, .atomic_flush = ltdc_crtc_atomic_flush,
.atomic_enable = ltdc_crtc_atomic_enable, .atomic_enable = ltdc_crtc_atomic_enable,

1
drivers/gpu/drm/stm/ltdc.h
View File

@ -28,7 +28,6 @@ struct ltdc_device {
bool is_panel_bridge; bool is_panel_bridge;
struct mutex err_lock; /* protecting error_status */ struct mutex err_lock; /* protecting error_status */
struct ltdc_caps caps; struct ltdc_caps caps;
u32 clut[256]; /* color look up table */
u32 error_status; u32 error_status;
u32 irq_status; u32 irq_status;
}; };