p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

pipe: Allow pipes to have kernel-reserved slots 

Split pipe->ring_size into two numbers:

 (1) pipe->ring_size - indicates the hard size of the pipe ring.

 (2) pipe->max_usage - indicates the maximum number of pipe ring slots that
     userspace orchestrated events can fill.

This allows for a pipe that is both writable by the general kernel
notification facility and by userspace, allowing plenty of ring space for
notifications to be added whilst preventing userspace from being able to
pin too much unswappable kernel space.

Signed-off-by: David Howells <dhowells@redhat.com>
This commit is contained in:
David Howells 2019-10-16 16:47:32 +01:00
parent 8cefc107ca
commit 6718b6f855
5 changed files with 30 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
fs/fuse/dev.c
View File

@ -703,7 +703,7 @@ static int fuse_copy_fill(struct fuse_copy_state *cs)
cs->pipebufs++; cs->pipebufs++;
cs->nr_segs--; cs->nr_segs--;
} else { } else {
if (cs->nr_segs >= cs->pipe->ring_size) if (cs->nr_segs >= cs->pipe->max_usage)
return -EIO; return -EIO;
page = alloc_page(GFP_HIGHUSER); page = alloc_page(GFP_HIGHUSER);
@ -879,7 +879,7 @@ static int fuse_ref_page(struct fuse_copy_state *cs, struct page *page,
struct pipe_buffer *buf; struct pipe_buffer *buf;
int err; int err;
if (cs->nr_segs >= cs->pipe->ring_size) if (cs->nr_segs >= cs->pipe->max_usage)
return -EIO; return -EIO;
err = unlock_request(cs->req); err = unlock_request(cs->req);
@ -1341,7 +1341,7 @@ static ssize_t fuse_dev_splice_read(struct file *in, loff_t *ppos,
if (!fud) if (!fud)
return -EPERM; return -EPERM;
bufs = kvmalloc_array(pipe->ring_size, sizeof(struct pipe_buffer), bufs = kvmalloc_array(pipe->max_usage, sizeof(struct pipe_buffer),
GFP_KERNEL); GFP_KERNEL);
if (!bufs) if (!bufs)
return -ENOMEM; return -ENOMEM;
@ -1353,7 +1353,7 @@ static ssize_t fuse_dev_splice_read(struct file *in, loff_t *ppos,
if (ret < 0) if (ret < 0)
goto out; goto out;
if (pipe_occupancy(pipe->head, pipe->tail) + cs.nr_segs > pipe->ring_size) { if (pipe_occupancy(pipe->head, pipe->tail) + cs.nr_segs > pipe->max_usage) {
ret = -EIO; ret = -EIO;
goto out; goto out;
} }

10
fs/pipe.c
View File

@ -404,7 +404,7 @@ pipe_write(struct kiocb *iocb, struct iov_iter *from)
tail = pipe->tail; tail = pipe->tail;
head = pipe->head; head = pipe->head;
max_usage = pipe->ring_size; max_usage = pipe->max_usage;
mask = pipe->ring_size - 1; mask = pipe->ring_size - 1;
/* We try to merge small writes */ /* We try to merge small writes */
@ -571,7 +571,7 @@ pipe_poll(struct file *filp, poll_table *wait)
} }
if (filp->f_mode & FMODE_WRITE) { if (filp->f_mode & FMODE_WRITE) {
if (!pipe_full(head, tail, pipe->ring_size)) if (!pipe_full(head, tail, pipe->max_usage))
mask |= EPOLLOUT | EPOLLWRNORM; mask |= EPOLLOUT | EPOLLWRNORM;
/* /*
* Most Unices do not set EPOLLERR for FIFOs but on Linux they * Most Unices do not set EPOLLERR for FIFOs but on Linux they
@ -696,6 +696,7 @@ struct pipe_inode_info *alloc_pipe_info(void)
if (pipe->bufs) { if (pipe->bufs) {
init_waitqueue_head(&pipe->wait); init_waitqueue_head(&pipe->wait);
pipe->r_counter = pipe->w_counter = 1; pipe->r_counter = pipe->w_counter = 1;
pipe->max_usage = pipe_bufs;
pipe->ring_size = pipe_bufs; pipe->ring_size = pipe_bufs;
pipe->user = user; pipe->user = user;
mutex_init(&pipe->mutex); mutex_init(&pipe->mutex);
@ -1150,9 +1151,10 @@ static long pipe_set_size(struct pipe_inode_info *pipe, unsigned long arg)
kfree(pipe->bufs); kfree(pipe->bufs);
pipe->bufs = bufs; pipe->bufs = bufs;
pipe->ring_size = nr_slots; pipe->ring_size = nr_slots;
pipe->max_usage = nr_slots;
pipe->tail = tail; pipe->tail = tail;
pipe->head = head; pipe->head = head;
return pipe->ring_size * PAGE_SIZE; return pipe->max_usage * PAGE_SIZE;
out_revert_acct: out_revert_acct:
(void) account_pipe_buffers(pipe->user, nr_slots, pipe->ring_size); (void) account_pipe_buffers(pipe->user, nr_slots, pipe->ring_size);
@ -1185,7 +1187,7 @@ long pipe_fcntl(struct file *file, unsigned int cmd, unsigned long arg)
ret = pipe_set_size(pipe, arg); ret = pipe_set_size(pipe, arg);
break; break;
case F_GETPIPE_SZ: case F_GETPIPE_SZ:
ret = pipe->ring_size * PAGE_SIZE; ret = pipe->max_usage * PAGE_SIZE;
break; break;
default: default:
ret = -EINVAL; ret = -EINVAL;

26
fs/splice.c
View File

@ -199,7 +199,7 @@ ssize_t splice_to_pipe(struct pipe_inode_info *pipe,
goto out; goto out;
} }
while (!pipe_full(head, tail, pipe->ring_size)) { while (!pipe_full(head, tail, pipe->max_usage)) {
struct pipe_buffer *buf = &pipe->bufs[head & mask]; struct pipe_buffer *buf = &pipe->bufs[head & mask];
buf->page = spd->pages[page_nr]; buf->page = spd->pages[page_nr];
@ -239,7 +239,7 @@ ssize_t add_to_pipe(struct pipe_inode_info *pipe, struct pipe_buffer *buf)
if (unlikely(!pipe->readers)) { if (unlikely(!pipe->readers)) {
send_sig(SIGPIPE, current, 0); send_sig(SIGPIPE, current, 0);
ret = -EPIPE; ret = -EPIPE;
} else if (pipe_full(head, tail, pipe->ring_size)) { } else if (pipe_full(head, tail, pipe->max_usage)) {
ret = -EAGAIN; ret = -EAGAIN;
} else { } else {
pipe->bufs[head & mask] = *buf; pipe->bufs[head & mask] = *buf;
@ -257,7 +257,7 @@ EXPORT_SYMBOL(add_to_pipe);
*/ */
int splice_grow_spd(const struct pipe_inode_info *pipe, struct splice_pipe_desc *spd) int splice_grow_spd(const struct pipe_inode_info *pipe, struct splice_pipe_desc *spd)
{ {
unsigned int max_usage = READ_ONCE(pipe->ring_size); unsigned int max_usage = READ_ONCE(pipe->max_usage);
spd->nr_pages_max = max_usage; spd->nr_pages_max = max_usage;
if (max_usage <= PIPE_DEF_BUFFERS) if (max_usage <= PIPE_DEF_BUFFERS)
@ -381,7 +381,7 @@ static ssize_t default_file_splice_read(struct file *in, loff_t *ppos,
ssize_t res; ssize_t res;
int i; int i;
if (pipe_full(pipe->head, pipe->tail, pipe->ring_size)) if (pipe_full(pipe->head, pipe->tail, pipe->max_usage))
return -EAGAIN; return -EAGAIN;
/* /*
@ -698,7 +698,7 @@ iter_file_splice_write(struct pipe_inode_info *pipe, struct file *out,
.pos = *ppos, .pos = *ppos,
.u.file = out, .u.file = out,
}; };
int nbufs = pipe->ring_size; int nbufs = pipe->max_usage;
struct bio_vec *array = kcalloc(nbufs, sizeof(struct bio_vec), struct bio_vec *array = kcalloc(nbufs, sizeof(struct bio_vec),
GFP_KERNEL); GFP_KERNEL);
ssize_t ret; ssize_t ret;
@ -721,9 +721,9 @@ iter_file_splice_write(struct pipe_inode_info *pipe, struct file *out,
if (ret <= 0) if (ret <= 0)
break; break;
if (unlikely(nbufs < pipe->ring_size)) { if (unlikely(nbufs < pipe->max_usage)) {
kfree(array); kfree(array);
nbufs = pipe->ring_size; nbufs = pipe->max_usage;
array = kcalloc(nbufs, sizeof(struct bio_vec), array = kcalloc(nbufs, sizeof(struct bio_vec),
GFP_KERNEL); GFP_KERNEL);
if (!array) { if (!array) {
@ -963,7 +963,7 @@ ssize_t splice_direct_to_actor(struct file *in, struct splice_desc *sd,
loff_t pos = sd->pos, prev_pos = pos; loff_t pos = sd->pos, prev_pos = pos;
/* Don't try to read more the pipe has space for. */ /* Don't try to read more the pipe has space for. */
p_space = pipe->ring_size - p_space = pipe->max_usage -
pipe_occupancy(pipe->head, pipe->tail); pipe_occupancy(pipe->head, pipe->tail);
read_len = min_t(size_t, len, p_space << PAGE_SHIFT); read_len = min_t(size_t, len, p_space << PAGE_SHIFT);
ret = do_splice_to(in, &pos, pipe, read_len, flags); ret = do_splice_to(in, &pos, pipe, read_len, flags);
@ -1090,7 +1090,7 @@ static int wait_for_space(struct pipe_inode_info *pipe, unsigned flags)
send_sig(SIGPIPE, current, 0); send_sig(SIGPIPE, current, 0);
return -EPIPE; return -EPIPE;
} }
if (!pipe_full(pipe->head, pipe->tail, pipe->ring_size)) if (!pipe_full(pipe->head, pipe->tail, pipe->max_usage))
return 0; return 0;
if (flags & SPLICE_F_NONBLOCK) if (flags & SPLICE_F_NONBLOCK)
return -EAGAIN; return -EAGAIN;
@ -1498,13 +1498,13 @@ static int opipe_prep(struct pipe_inode_info *pipe, unsigned int flags)
* Check pipe occupancy without the inode lock first. This function * Check pipe occupancy without the inode lock first. This function
* is speculative anyways, so missing one is ok. * is speculative anyways, so missing one is ok.
*/ */
if (pipe_full(pipe->head, pipe->tail, pipe->ring_size)) if (pipe_full(pipe->head, pipe->tail, pipe->max_usage))
return 0; return 0;
ret = 0; ret = 0;
pipe_lock(pipe); pipe_lock(pipe);
while (pipe_full(pipe->head, pipe->tail, pipe->ring_size)) { while (pipe_full(pipe->head, pipe->tail, pipe->max_usage)) {
if (!pipe->readers) { if (!pipe->readers) {
send_sig(SIGPIPE, current, 0); send_sig(SIGPIPE, current, 0);
ret = -EPIPE; ret = -EPIPE;
@ -1584,7 +1584,7 @@ static int splice_pipe_to_pipe(struct pipe_inode_info *ipipe,
* pipe is empty or the output pipe is full. * pipe is empty or the output pipe is full.
*/ */
if (pipe_empty(i_head, i_tail) || if (pipe_empty(i_head, i_tail) ||
pipe_full(o_head, o_tail, opipe->ring_size)) { pipe_full(o_head, o_tail, opipe->max_usage)) {
/* Already processed some buffers, break */ /* Already processed some buffers, break */
if (ret) if (ret)
break; break;
@ -1706,7 +1706,7 @@ static int link_pipe(struct pipe_inode_info *ipipe,
* output room, break. * output room, break.
*/ */
if (pipe_empty(i_head, i_tail) || if (pipe_empty(i_head, i_tail) ||
pipe_full(o_head, o_tail, opipe->ring_size)) pipe_full(o_head, o_tail, opipe->max_usage))
break; break;
ibuf = &ipipe->bufs[i_tail & i_mask]; ibuf = &ipipe->bufs[i_tail & i_mask];

6
include/linux/pipe_fs_i.h
View File

@ -32,6 +32,7 @@ struct pipe_buffer {
* @wait: reader/writer wait point in case of empty/full pipe * @wait: reader/writer wait point in case of empty/full pipe
* @head: The point of buffer production * @head: The point of buffer production
* @tail: The point of buffer consumption * @tail: The point of buffer consumption
* @max_usage: The maximum number of slots that may be used in the ring
* @ring_size: total number of buffers (should be a power of 2) * @ring_size: total number of buffers (should be a power of 2)
* @tmp_page: cached released page * @tmp_page: cached released page
* @readers: number of current readers of this pipe * @readers: number of current readers of this pipe
@ -50,6 +51,7 @@ struct pipe_inode_info {
wait_queue_head_t wait; wait_queue_head_t wait;
unsigned int head; unsigned int head;
unsigned int tail; unsigned int tail;
unsigned int max_usage;
unsigned int ring_size; unsigned int ring_size;
unsigned int readers; unsigned int readers;
unsigned int writers; unsigned int writers;
@ -150,9 +152,11 @@ static inline unsigned int pipe_space_for_user(unsigned int head, unsigned int t
unsigned int p_occupancy, p_space; unsigned int p_occupancy, p_space;
p_occupancy = pipe_occupancy(head, tail); p_occupancy = pipe_occupancy(head, tail);
if (p_occupancy >= pipe->ring_size) if (p_occupancy >= pipe->max_usage)
return 0; return 0;
p_space = pipe->ring_size - p_occupancy; p_space = pipe->ring_size - p_occupancy;
if (p_space > pipe->max_usage)
p_space = pipe->max_usage;
return p_space; return p_space;
} }

4
lib/iov_iter.c
View File

@ -395,7 +395,7 @@ static size_t copy_page_to_iter_pipe(struct page *page, size_t offset, size_t by
i_head++; i_head++;
buf = &pipe->bufs[i_head & p_mask]; buf = &pipe->bufs[i_head & p_mask];
} }
if (pipe_full(i_head, p_tail, pipe->ring_size)) if (pipe_full(i_head, p_tail, pipe->max_usage))
return 0; return 0;
buf->ops = &page_cache_pipe_buf_ops; buf->ops = &page_cache_pipe_buf_ops;
@ -528,7 +528,7 @@ static size_t push_pipe(struct iov_iter *i, size_t size,
pipe->bufs[iter_head & p_mask].len = PAGE_SIZE; pipe->bufs[iter_head & p_mask].len = PAGE_SIZE;
iter_head++; iter_head++;
} }
while (!pipe_full(iter_head, p_tail, pipe->ring_size)) { while (!pipe_full(iter_head, p_tail, pipe->max_usage)) {
struct pipe_buffer *buf = &pipe->bufs[iter_head & p_mask]; struct pipe_buffer *buf = &pipe->bufs[iter_head & p_mask];
struct page *page = alloc_page(GFP_USER); struct page *page = alloc_page(GFP_USER);
if (!page) if (!page)