p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

net: phy: at803x: simplify using devm_gpiod_get_optional and its 4th argument 

Since 39b2bbe3d7 (gpio: add flags argument to gpiod_get*() functions)
which appeared in v3.17-rc1, the gpiod_get* functions take an additional
parameter that allows to specify direction and initial value for output.
Moreover use devm_gpiod_get_optional instead of ignoring all errors
returned by devm_gpiod_get and simplify accordingly.

The result is more strict error handling which is good.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Uwe Kleine-König 2015-03-31 22:08:45 +02:00 committed by David S. Miller
parent 906a7985f7
commit 687908c2b6
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/net/phy/at803x.c
View File

@ -192,16 +192,17 @@ static int at803x_probe(struct phy_device *phydev)
{ {
struct device *dev = &phydev->dev; struct device *dev = &phydev->dev;
struct at803x_priv *priv; struct at803x_priv *priv;
struct gpio_desc *gpiod_reset;
priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
if (!priv) if (!priv)
return -ENOMEM; return -ENOMEM;
priv->gpiod_reset = devm_gpiod_get(dev, "reset"); gpiod_reset = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH);
if (IS_ERR(priv->gpiod_reset)) if (IS_ERR(gpiod_reset))
priv->gpiod_reset = NULL; return PTR_ERR(gpiod_reset);
else
gpiod_direction_output(priv->gpiod_reset, 1); priv->gpiod_reset = gpiod_reset;
phydev->priv = priv; phydev->priv = priv;