net/smc: clear link during SMC client link down processing

In a link-down condition we notify the SMC server and expect that the
server will finally trigger the link clear processing on the client
side. This could fail when anything along this notification path goes
wrong. Clear the link as part of SMC client link-down processing to
prevent dangling links.

Reviewed-by: Ursula Braun <ubraun@linux.ibm.com>
Fixes: 541afa10c1 ("net/smc: add smcr_port_err() and smcr_link_down() processing")
Signed-off-by: Karsten Graul <kgraul@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Karsten Graul 2020-07-18 15:06:10 +02:00 committed by David S. Miller
parent a35fffbf98
commit 68fd894203
1 changed files with 3 additions and 1 deletions

View File

@ -1204,10 +1204,12 @@ static void smcr_link_down(struct smc_link *lnk)
SMC_LLC_WAIT_TIME); SMC_LLC_WAIT_TIME);
mutex_lock(&lgr->llc_conf_mutex); mutex_lock(&lgr->llc_conf_mutex);
} }
if (!list_empty(&lgr->list)) if (!list_empty(&lgr->list)) {
smc_llc_send_delete_link(to_lnk, del_link_id, smc_llc_send_delete_link(to_lnk, del_link_id,
SMC_LLC_REQ, true, SMC_LLC_REQ, true,
SMC_LLC_DEL_LOST_PATH); SMC_LLC_DEL_LOST_PATH);
smcr_link_clear(lnk, true);
}
wake_up(&lgr->llc_flow_waiter); /* wake up next waiter */ wake_up(&lgr->llc_flow_waiter); /* wake up next waiter */
} }
} }