p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fs: dlm: fix potential buffer overflow 

This patch fixes an potential overflow in sscanf and the maximum
declared string parsing length which seems to be excluding the null
termination symbol. This patch will just add one byte to be prepared on
a string with length of DLM_RESNAME_MAXLEN including the null
termination symbol.

Fixes: 5054e79de9 ("fs: dlm: add lkb debugfs functionality")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Alexander Aring <aahringo@redhat.com>
Signed-off-by: David Teigland <teigland@redhat.com>
This commit is contained in:
Alexander Aring 2021-11-12 10:08:01 -05:00 committed by David Teigland
parent c8b9f34e22
commit 6a628fa438
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
fs/dlm/debug_fs.c
View File

@ -640,7 +640,7 @@ static ssize_t table_write2(struct file *file, const char __user *user_buf,
{ {
struct seq_file *seq = file->private_data; struct seq_file *seq = file->private_data;
int n, len, lkb_nodeid, lkb_status, error; int n, len, lkb_nodeid, lkb_status, error;
char name[DLM_RESNAME_MAXLEN] = {}; char name[DLM_RESNAME_MAXLEN + 1] = {};
struct dlm_ls *ls = seq->private; struct dlm_ls *ls = seq->private;
unsigned int lkb_flags; unsigned int lkb_flags;
char buf[256] = {}; char buf[256] = {};