p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

staging: unisys: visorbus: keep the success path on the left side 

If you can't find the dev, it is an error. Indent for the error, instead
of the success.

Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Tim Sell <timothy.sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
David Kershner 2017-09-27 13:14:35 -04:00 committed by Greg Kroah-Hartman
parent b11dffc481
commit 6c073dabce
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/staging/unisys/visorbus/visorchipset.c
View File

@ -309,7 +309,6 @@ struct visor_device *visorbus_get_device_by_id(u32 bus_no, u32 dev_no,
{
struct device *dev;
struct device *dev_start = NULL;
struct visor_device *vdev = NULL;
struct visor_busdev id = {
.bus_no = bus_no,
.dev_no = dev_no
@ -319,9 +318,9 @@ struct visor_device *visorbus_get_device_by_id(u32 bus_no, u32 dev_no,
dev_start = &from->device;
dev = bus_find_device(&visorbus_type, dev_start, (void *)&id,
match_visorbus_dev_by_id);
if (dev)
vdev = to_visor_device(dev);
return vdev;
if (!dev)
return NULL;
return to_visor_device(dev);
}
static void controlvm_init_response(struct controlvm_message *msg,