p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

crypto: ccp - Use memdup_user() rather than duplicating its implementation 

Reuse existing functionality from memdup_user() instead of keeping
duplicate source code.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Reviewed-by: Brijesh Singh <brijesh.singh@amd.com>
Acked-by: Gary R Hook <gary.hook@amd.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
This commit is contained in:
Markus Elfring 2018-03-05 13:50:13 +01:00 committed by Herbert Xu
parent 0ee991be4c
commit 6c51ddddac
1 changed files with 1 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
drivers/crypto/ccp/psp-dev.c
View File

@ -367,8 +367,6 @@ static int sev_ioctl_do_pek_csr(struct sev_issue_cmd *argp)
void *psp_copy_user_blob(u64 __user uaddr, u32 len) void *psp_copy_user_blob(u64 __user uaddr, u32 len)
{ {
void *data;
if (!uaddr || !len) if (!uaddr || !len)
return ERR_PTR(-EINVAL); return ERR_PTR(-EINVAL);
@ -376,18 +374,7 @@ void *psp_copy_user_blob(u64 __user uaddr, u32 len)
if (len > SEV_FW_BLOB_MAX_SIZE) if (len > SEV_FW_BLOB_MAX_SIZE)
return ERR_PTR(-EINVAL); return ERR_PTR(-EINVAL);
data = kmalloc(len, GFP_KERNEL); return memdup_user((void __user *)(uintptr_t)uaddr, len);
if (!data)
return ERR_PTR(-ENOMEM);
if (copy_from_user(data, (void __user *)(uintptr_t)uaddr, len))
goto e_free;
return data;
e_free:
kfree(data);
return ERR_PTR(-EFAULT);
} }
EXPORT_SYMBOL_GPL(psp_copy_user_blob); EXPORT_SYMBOL_GPL(psp_copy_user_blob);