p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

misc: mic: scif: Remove unused variable 

Clang warns when a variable is assigned to itself.

drivers/misc/mic/scif/scif_dma.c:1577:12: warning: explicitly assigning
value of variable of type 'bool' (aka '_Bool') to itself [-Wself-assign]
        dst_local = dst_local;
        ~~~~~~~~~ ^ ~~~~~~~~~
1 warning generated.

This is usually done to avoid an unused variable warning, which is the
case here. dst_local is used nowhere in this function, which has been
the case since the initial code drop in commit 7cc31cd277 ("misc: mic:
SCIF DMA and CPU copy interface") in 2015. Just remove the variable, it
can be added back if it was intended to be used.

Link: https://github.com/ClangBuiltLinux/linux/issues/107
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Nathan Chancellor 2018-09-19 12:50:22 -07:00 committed by Greg Kroah-Hartman
parent 7052c5e128
commit 6dbfdc1a4e
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/misc/mic/scif/scif_dma.c
View File

@ -1553,7 +1553,7 @@ static int scif_rma_list_dma_copy_wrapper(struct scif_endpt *epd,
int src_cache_off, dst_cache_off; int src_cache_off, dst_cache_off;
s64 src_offset = work->src_offset, dst_offset = work->dst_offset; s64 src_offset = work->src_offset, dst_offset = work->dst_offset;
u8 *temp = NULL; u8 *temp = NULL;
bool src_local = true, dst_local = false; bool src_local = true;
struct scif_dma_comp_cb *comp_cb; struct scif_dma_comp_cb *comp_cb;
dma_addr_t src_dma_addr, dst_dma_addr; dma_addr_t src_dma_addr, dst_dma_addr;
int err; int err;
@ -1572,9 +1572,7 @@ static int scif_rma_list_dma_copy_wrapper(struct scif_endpt *epd,
src_dma_addr = __scif_off_to_dma_addr(work->src_window, src_offset); src_dma_addr = __scif_off_to_dma_addr(work->src_window, src_offset);
dst_dma_addr = __scif_off_to_dma_addr(work->dst_window, dst_offset); dst_dma_addr = __scif_off_to_dma_addr(work->dst_window, dst_offset);
src_local = work->src_window->type == SCIF_WINDOW_SELF; src_local = work->src_window->type == SCIF_WINDOW_SELF;
dst_local = work->dst_window->type == SCIF_WINDOW_SELF;
dst_local = dst_local;
/* Allocate dma_completion cb */ /* Allocate dma_completion cb */
comp_cb = kzalloc(sizeof(*comp_cb), GFP_KERNEL); comp_cb = kzalloc(sizeof(*comp_cb), GFP_KERNEL);
if (!comp_cb) if (!comp_cb)