powerpc/powernv: Reserve additional space for IOV BAR according to the number of total_pe
On PHB3, PF IOV BAR will be covered by M64 BAR to have better PE isolation. M64 BAR is a type of hardware resource in PHB3, which could map a range of MMIO to PE numbers on powernv platform. And this range is divided equally by the number of total_pe with each divided range mapping to a PE number. Also, the M64 BAR must map a MMIO range with power-of-two size. The total_pe number is usually different from total_VFs, which can lead to a conflict between MMIO space and the PE number. For example, if total_VFs is 128 and total_pe is 256, the second half of M64 BAR will be part of other PCI device, which may already belong to other PEs. This patch prevents the conflict by reserving additional space for the PF IOV BAR, which is total_pe number of VF's BAR size. [bhelgaas: make dev_printk() output more consistent, index resource[] conventionally] Signed-off-by: Wei Yang <weiyang@linux.vnet.ibm.com> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
This commit is contained in:
parent
9e8d4a19ab
commit
6e628c7d33
|
@ -250,6 +250,10 @@ struct machdep_calls {
|
|||
/* Reset the secondary bus of bridge */
|
||||
void (*pcibios_reset_secondary_bus)(struct pci_dev *dev);
|
||||
|
||||
#ifdef CONFIG_PCI_IOV
|
||||
void (*pcibios_fixup_sriov)(struct pci_dev *pdev);
|
||||
#endif /* CONFIG_PCI_IOV */
|
||||
|
||||
/* Called to shutdown machine specific hardware not already controlled
|
||||
* by other drivers.
|
||||
*/
|
||||
|
|
|
@ -178,6 +178,9 @@ struct pci_dn {
|
|||
#define IODA_INVALID_PE (-1)
|
||||
#ifdef CONFIG_PPC_POWERNV
|
||||
int pe_number;
|
||||
#ifdef CONFIG_PCI_IOV
|
||||
u16 vfs_expanded; /* number of VFs IOV BAR expanded */
|
||||
#endif /* CONFIG_PCI_IOV */
|
||||
#endif
|
||||
struct list_head child_list;
|
||||
struct list_head list;
|
||||
|
|
|
@ -990,6 +990,12 @@ int pcibios_add_device(struct pci_dev *dev)
|
|||
*/
|
||||
if (dev->bus->is_added)
|
||||
pcibios_setup_device(dev);
|
||||
|
||||
#ifdef CONFIG_PCI_IOV
|
||||
if (ppc_md.pcibios_fixup_sriov)
|
||||
ppc_md.pcibios_fixup_sriov(dev);
|
||||
#endif /* CONFIG_PCI_IOV */
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
|
|
|
@ -1749,6 +1749,46 @@ static void pnv_pci_init_ioda_msis(struct pnv_phb *phb)
|
|||
static void pnv_pci_init_ioda_msis(struct pnv_phb *phb) { }
|
||||
#endif /* CONFIG_PCI_MSI */
|
||||
|
||||
#ifdef CONFIG_PCI_IOV
|
||||
static void pnv_pci_ioda_fixup_iov_resources(struct pci_dev *pdev)
|
||||
{
|
||||
struct pci_controller *hose;
|
||||
struct pnv_phb *phb;
|
||||
struct resource *res;
|
||||
int i;
|
||||
resource_size_t size;
|
||||
struct pci_dn *pdn;
|
||||
|
||||
if (!pdev->is_physfn || pdev->is_added)
|
||||
return;
|
||||
|
||||
hose = pci_bus_to_host(pdev->bus);
|
||||
phb = hose->private_data;
|
||||
|
||||
pdn = pci_get_pdn(pdev);
|
||||
pdn->vfs_expanded = 0;
|
||||
|
||||
for (i = 0; i < PCI_SRIOV_NUM_BARS; i++) {
|
||||
res = &pdev->resource[i + PCI_IOV_RESOURCES];
|
||||
if (!res->flags || res->parent)
|
||||
continue;
|
||||
if (!pnv_pci_is_mem_pref_64(res->flags)) {
|
||||
dev_warn(&pdev->dev, "Skipping expanding VF BAR%d: %pR\n",
|
||||
i, res);
|
||||
continue;
|
||||
}
|
||||
|
||||
dev_dbg(&pdev->dev, " Fixing VF BAR%d: %pR to\n", i, res);
|
||||
size = pci_iov_resource_size(pdev, i + PCI_IOV_RESOURCES);
|
||||
res->end = res->start + size * phb->ioda.total_pe - 1;
|
||||
dev_dbg(&pdev->dev, " %pR\n", res);
|
||||
dev_info(&pdev->dev, "VF BAR%d: %pR (expanded to %d VFs for PE alignment)",
|
||||
i, res, phb->ioda.total_pe);
|
||||
}
|
||||
pdn->vfs_expanded = phb->ioda.total_pe;
|
||||
}
|
||||
#endif /* CONFIG_PCI_IOV */
|
||||
|
||||
/*
|
||||
* This function is supposed to be called on basis of PE from top
|
||||
* to bottom style. So the the I/O or MMIO segment assigned to
|
||||
|
@ -2122,6 +2162,9 @@ static void __init pnv_pci_init_ioda_phb(struct device_node *np,
|
|||
ppc_md.pcibios_enable_device_hook = pnv_pci_enable_device_hook;
|
||||
ppc_md.pcibios_window_alignment = pnv_pci_window_alignment;
|
||||
ppc_md.pcibios_reset_secondary_bus = pnv_pci_reset_secondary_bus;
|
||||
#ifdef CONFIG_PCI_IOV
|
||||
ppc_md.pcibios_fixup_sriov = pnv_pci_ioda_fixup_iov_resources;
|
||||
#endif /* CONFIG_PCI_IOV */
|
||||
pci_add_flags(PCI_REASSIGN_ALL_RSRC);
|
||||
|
||||
/* Reset IODA tables to a clean state */
|
||||
|
|
Loading…
Reference in New Issue