p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

scsi: sd: improve TUR handling in sd_check_events 

Remove bogus evaluations of retval and sshdr when the device is offline,
and fix a possible NULL pointer dereference by allocating the 8 byte
sized sense header on stack.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Christoph Hellwig 2017-02-14 20:15:56 +01:00 committed by Martin K. Petersen
parent 148cff67b4
commit 6fa2b8f9e3
1 changed files with 11 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
drivers/scsi/sd.c
View File

@ -1425,7 +1425,6 @@ static unsigned int sd_check_events(struct gendisk *disk, unsigned int clearing)
{ {
struct scsi_disk *sdkp = scsi_disk_get(disk); struct scsi_disk *sdkp = scsi_disk_get(disk);
struct scsi_device *sdp; struct scsi_device *sdp;
struct scsi_sense_hdr *sshdr = NULL;
int retval; int retval;
if (!sdkp) if (!sdkp)
@ -1454,22 +1453,21 @@ static unsigned int sd_check_events(struct gendisk *disk, unsigned int clearing)
* by sd_spinup_disk() from sd_revalidate_disk(), which happens whenever * by sd_spinup_disk() from sd_revalidate_disk(), which happens whenever
* sd_revalidate() is called. * sd_revalidate() is called.
*/ */
retval = -ENODEV;
if (scsi_block_when_processing_errors(sdp)) { if (scsi_block_when_processing_errors(sdp)) {
sshdr = kzalloc(sizeof(*sshdr), GFP_KERNEL); struct scsi_sense_hdr sshdr = { 0, };
retval = scsi_test_unit_ready(sdp, SD_TIMEOUT, SD_MAX_RETRIES, retval = scsi_test_unit_ready(sdp, SD_TIMEOUT, SD_MAX_RETRIES,
sshdr); &sshdr);
}
/* failed to execute TUR, assume media not present */ /* failed to execute TUR, assume media not present */
if (host_byte(retval)) { if (host_byte(retval)) {
set_media_not_present(sdkp); set_media_not_present(sdkp);
goto out; goto out;
} }
if (media_not_present(sdkp, sshdr)) if (media_not_present(sdkp, &sshdr))
goto out; goto out;
}
/* /*
* For removable scsi disk we have to recognise the presence * For removable scsi disk we have to recognise the presence
@ -1485,7 +1483,6 @@ static unsigned int sd_check_events(struct gendisk *disk, unsigned int clearing)
* Medium present state has changed in either direction. * Medium present state has changed in either direction.
* Device has indicated UNIT_ATTENTION. * Device has indicated UNIT_ATTENTION.
*/ */
kfree(sshdr);
retval = sdp->changed ? DISK_EVENT_MEDIA_CHANGE : 0; retval = sdp->changed ? DISK_EVENT_MEDIA_CHANGE : 0;
sdp->changed = 0; sdp->changed = 0;
scsi_disk_put(sdkp); scsi_disk_put(sdkp);