p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

hwrng: chaoskey - drop workaround for old hwrng core limitation 

The hwrng core used to mask 'quality' with 1023; that has been removed
in commit 506bf0c046 ("hwrng: core - allow
perfect entropy from hardware devices"), so we can now just set quality
to 1024.

Signed-off-by: Julien Cristau <jcristau@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Julien Cristau 2016-10-04 22:49:30 +02:00 committed by Greg Kroah-Hartman
parent 054d4b7b57
commit 6fbbcf3873
1 changed files with 1 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/usb/misc/chaoskey.c
View File

@ -215,19 +215,7 @@ static int chaoskey_probe(struct usb_interface *interface,
dev->hwrng.name = dev->name ? dev->name : chaoskey_driver.name;
dev->hwrng.read = chaoskey_rng_read;
/* Set the 'quality' metric. Quality is measured in units of
* 1/1024's of a bit ("mills"). This should be set to 1024,
* but there is a bug in the hwrng core which masks it with
* 1023.
*
* The patch that has been merged to the crypto development
* tree for that bug limits the value to 1024 at most, so by
* setting this to 1024 + 1023, we get 1023 before the fix is
* merged and 1024 afterwards. We'll patch this driver once
* both bits of code are in the same tree.
*/
dev->hwrng.quality = 1024 + 1023;
dev->hwrng.quality = 1024;
dev->hwrng_registered = (hwrng_register(&dev->hwrng) == 0);
if (!dev->hwrng_registered)