p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

staging: fsl-mc: move comparison before strcmp() call 

Move comparison before the strcmp() in this if statement, and slightly
increase efficiency by not making the strcmp() each time the if gets
evaluated but only when the comparison is true.
This was suggested in a review comment.

Signed-off-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Laurentiu Tudor 2017-06-27 17:41:21 +03:00 committed by Greg Kroah-Hartman
parent ce73724d4d
commit 714cc27d41
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/staging/fsl-mc/bus/dprc-driver.c
View File

@ -29,8 +29,9 @@ struct dprc_child_objs {
static bool fsl_mc_device_match(struct fsl_mc_device *mc_dev,
struct dprc_obj_desc *obj_desc)
{
return !strcmp(mc_dev->obj_desc.type, obj_desc->type) &&
mc_dev->obj_desc.id == obj_desc->id;
return mc_dev->obj_desc.id == obj_desc->id &&
!strcmp(mc_dev->obj_desc.type, obj_desc->type);
}
static int __fsl_mc_device_remove_if_not_in_mc(struct device *dev, void *data)