p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

EDAC: Delete unnecessary checks before pci_dev_put() 

The pci_dev_put() function tests whether its argument is NULL and thus
the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Link: http://lkml.kernel.org/r/54CFC12C.9010002@users.sourceforge.net
Signed-off-by: Borislav Petkov <bp@suse.de>
This commit is contained in:
Markus Elfring 2015-02-02 18:26:34 +01:00 committed by Borislav Petkov
parent c517d838eb
commit 7260194595
4 changed files with 5 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/edac/i82443bxgx_edac.c
View File

@ -445,9 +445,7 @@ static int __init i82443bxgx_edacmc_init(void)
pci_unregister_driver(&i82443bxgx_edacmc_driver);
fail0:
if (mci_pdev != NULL)
pci_dev_put(mci_pdev);
pci_dev_put(mci_pdev);
return pci_rc;
}

9
drivers/edac/i82860_edac.c
View File

@ -343,20 +343,15 @@ static int __init i82860_init(void)
pci_unregister_driver(&i82860_driver);
fail0:
if (mci_pdev != NULL)
pci_dev_put(mci_pdev);
pci_dev_put(mci_pdev);
return pci_rc;
}
static void __exit i82860_exit(void)
{
edac_dbg(3, "\n");
pci_unregister_driver(&i82860_driver);
if (mci_pdev != NULL)
pci_dev_put(mci_pdev);
pci_dev_put(mci_pdev);
}
module_init(i82860_init);

4
drivers/edac/i82875p_edac.c
View File

@ -576,9 +576,7 @@ static int __init i82875p_init(void)
pci_unregister_driver(&i82875p_driver);
fail0:
if (mci_pdev != NULL)
pci_dev_put(mci_pdev);
pci_dev_put(mci_pdev);
return pci_rc;
}

4
drivers/edac/i82975x_edac.c
View File

@ -685,9 +685,7 @@ static int __init i82975x_init(void)
pci_unregister_driver(&i82975x_driver);
fail0:
if (mci_pdev != NULL)
pci_dev_put(mci_pdev);
pci_dev_put(mci_pdev);
return pci_rc;
}