p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

leds: triggers: simplify led_trigger_store 

led_trigger_store can be significantly simplified by using sysfs_streq().

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
This commit is contained in:
Heiner Kallweit 2016-03-08 23:08:36 +01:00 committed by Jacek Anaszewski
parent 1c430f9021
commit 7296c33ed1
1 changed files with 2 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
drivers/leds/led-triggers.c
View File

@ -34,9 +34,7 @@ ssize_t led_trigger_store(struct device *dev, struct device_attribute *attr,
const char *buf, size_t count) const char *buf, size_t count)
{ {
struct led_classdev *led_cdev = dev_get_drvdata(dev); struct led_classdev *led_cdev = dev_get_drvdata(dev);
char trigger_name[TRIG_NAME_MAX];
struct led_trigger *trig; struct led_trigger *trig;
size_t len;
int ret = count; int ret = count;
mutex_lock(&led_cdev->led_access); mutex_lock(&led_cdev->led_access);
@ -46,21 +44,14 @@ ssize_t led_trigger_store(struct device *dev, struct device_attribute *attr,
goto unlock; goto unlock;
} }
trigger_name[sizeof(trigger_name) - 1] = '\0'; if (sysfs_streq(buf, "none")) {
strncpy(trigger_name, buf, sizeof(trigger_name) - 1);
len = strlen(trigger_name);
if (len && trigger_name[len - 1] == '\n')
trigger_name[len - 1] = '\0';
if (!strcmp(trigger_name, "none")) {
led_trigger_remove(led_cdev); led_trigger_remove(led_cdev);
goto unlock; goto unlock;
} }
down_read(&triggers_list_lock); down_read(&triggers_list_lock);
list_for_each_entry(trig, &trigger_list, next_trig) { list_for_each_entry(trig, &trigger_list, next_trig) {
if (!strcmp(trigger_name, trig->name)) { if (sysfs_streq(buf, trig->name)) {
down_write(&led_cdev->trigger_lock); down_write(&led_cdev->trigger_lock);
led_trigger_set(led_cdev, trig); led_trigger_set(led_cdev, trig);
up_write(&led_cdev->trigger_lock); up_write(&led_cdev->trigger_lock);