p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

drm/nouveau/secboot/acr: fix memory leak 

In case memory resources for *bl_desc* were allocated, release
them before return.

Addresses-Coverity-ID: 1472021 ("Resource leak")
Fixes: 0d46690155 ("drm/nouveau/secboot/acr: Remove VLA usage")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: John Hubbard <jhubbard@nvidia.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Ben Skeggs <bskeggs@redhat.com>
This commit is contained in:
Gustavo A. R. Silva 2018-07-24 08:27:19 -05:00 committed by Ben Skeggs
parent 9340d77f53
commit 74a07c0a59
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
drivers/gpu/drm/nouveau/nvkm/subdev/secboot/acr_r352.c
View File

@ -801,6 +801,7 @@ acr_r352_load(struct nvkm_acr *_acr, struct nvkm_falcon *falcon,
bl = acr->hsbl_unload_blob; bl = acr->hsbl_unload_blob;
} else { } else {
nvkm_error(_acr->subdev, "invalid secure boot blob!\n"); nvkm_error(_acr->subdev, "invalid secure boot blob!\n");
kfree(bl_desc);
return -EINVAL; return -EINVAL;
} }