p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

mm/compaction: add missing annotation for compact_lock_irqsave 

Sparse reports a warning at compact_lock_irqsave()

warning: context imbalance in compact_lock_irqsave() - wrong count at exit

The root cause is the missing annotation at compact_lock_irqsave()
Add the missing __acquires(lock) annotation.

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Link: http://lkml.kernel.org/r/20200214204741.94112-6-jbi.octave@gmail.com
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Jules Irenge 2020-04-06 20:08:06 -07:00 committed by Linus Torvalds
parent bb8b93b5b6
commit 77337edee7
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
mm/compaction.c
View File

@ -481,6 +481,7 @@ static bool test_and_set_skip(struct compact_control *cc, struct page *page,
*/ */
static bool compact_lock_irqsave(spinlock_t *lock, unsigned long *flags, static bool compact_lock_irqsave(spinlock_t *lock, unsigned long *flags,
struct compact_control *cc) struct compact_control *cc)
__acquires(lock)
{ {
/* Track if the lock is contended in async mode */ /* Track if the lock is contended in async mode */
if (cc->mode == MIGRATE_ASYNC && !cc->contended) { if (cc->mode == MIGRATE_ASYNC && !cc->contended) {