p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

PCI: spear: Remove spear13xx_pcie_remove() 

Following compilation warning occurs when compiled with:
CONFIG_DEBUG_SECTION_MISMATCH=y

 WARNING: vmlinux.o(.init.data+0x3338): Section mismatch in reference from the
 variable spear13xx_pcie_driver to the function
 .exit.text:spear13xx_pcie_remove()

This driver isn't allowed to unload, and so doesn't have a *_exit() routine. But
it still has spear13xx_pcie_remove() marked with __exit.

As this driver can't unload, .remove() would never be called, right? So get rid
of it.

Fixes: 51b66a6ce1 (PCI: spear: Add PCIe driver for ST Microelectronics SPEAr13xx)
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Olof Johansson <olof@lixom.net>
This commit is contained in:
Viresh Kumar 2014-07-20 17:29:48 +05:30 committed by Olof Johansson
parent 6675ef212d
commit 779ae55bd8
1 changed files with 0 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/pci/host/pcie-spear13xx.c
View File

@ -365,17 +365,6 @@ static int __init spear13xx_pcie_probe(struct platform_device *pdev)
return ret;
}
static int __exit spear13xx_pcie_remove(struct platform_device *pdev)
{
struct spear13xx_pcie *spear13xx_pcie = platform_get_drvdata(pdev);
clk_disable_unprepare(spear13xx_pcie->clk);
phy_exit(spear13xx_pcie->phy);
return 0;
}
static const struct of_device_id spear13xx_pcie_of_match[] = {
{ .compatible = "st,spear1340-pcie", },
{},
@ -384,7 +373,6 @@ MODULE_DEVICE_TABLE(of, spear13xx_pcie_of_match);
static struct platform_driver spear13xx_pcie_driver __initdata = {
.probe = spear13xx_pcie_probe,
.remove = spear13xx_pcie_remove,
.driver = {
.name = "spear-pcie",
.owner = THIS_MODULE,