p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

firmware: arm_scmi: rename get_transition_latency and add_opps_to_device 

Most of the scmi code follows the suggestion from Greg KH on a totally
different thread[0] to have the subsystem name first, followed by the
noun and finally the verb with couple of these exceptions.

This patch fixes them so that all the functions names are aligned to
that practice.

[0] https://www.spinics.net/lists/arm-kernel/msg583673.html

Acked-by: Rafael J. Wysocki <rafael@kernel.org>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
This commit is contained in:
Sudeep Holla 2018-05-09 17:52:06 +01:00
parent 1baf47c2e5
commit 7859e08c1b
3 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/cpufreq/scmi-cpufreq.c
View File

@ -117,7 +117,7 @@ static int scmi_cpufreq_init(struct cpufreq_policy *policy)
return -ENODEV; return -ENODEV;
} }
ret = handle->perf_ops->add_opps_to_device(handle, cpu_dev); ret = handle->perf_ops->device_opps_add(handle, cpu_dev);
if (ret) { if (ret) {
dev_warn(cpu_dev, "failed to add opps to the device\n"); dev_warn(cpu_dev, "failed to add opps to the device\n");
return ret; return ret;
@ -164,7 +164,7 @@ static int scmi_cpufreq_init(struct cpufreq_policy *policy)
/* SCMI allows DVFS request for any domain from any CPU */ /* SCMI allows DVFS request for any domain from any CPU */
policy->dvfs_possible_from_any_cpu = true; policy->dvfs_possible_from_any_cpu = true;
latency = handle->perf_ops->get_transition_latency(handle, cpu_dev); latency = handle->perf_ops->transition_latency_get(handle, cpu_dev);
if (!latency) if (!latency)
latency = CPUFREQ_ETERNAL; latency = CPUFREQ_ETERNAL;

10
drivers/firmware/arm_scmi/perf.c
View File

@ -349,8 +349,8 @@ static int scmi_dev_domain_id(struct device *dev)
return clkspec.args[0]; return clkspec.args[0];
} }
static int scmi_dvfs_add_opps_to_device(const struct scmi_handle *handle, static int scmi_dvfs_device_opps_add(const struct scmi_handle *handle,
struct device *dev) struct device *dev)
{ {
int idx, ret, domain; int idx, ret, domain;
unsigned long freq; unsigned long freq;
@ -383,7 +383,7 @@ static int scmi_dvfs_add_opps_to_device(const struct scmi_handle *handle,
return 0; return 0;
} }
static int scmi_dvfs_get_transition_latency(const struct scmi_handle *handle, static int scmi_dvfs_transition_latency_get(const struct scmi_handle *handle,
struct device *dev) struct device *dev)
{ {
struct perf_dom_info *dom; struct perf_dom_info *dom;
@ -432,8 +432,8 @@ static struct scmi_perf_ops perf_ops = {
.level_set = scmi_perf_level_set, .level_set = scmi_perf_level_set,
.level_get = scmi_perf_level_get, .level_get = scmi_perf_level_get,
.device_domain_id = scmi_dev_domain_id, .device_domain_id = scmi_dev_domain_id,
.get_transition_latency = scmi_dvfs_get_transition_latency, .transition_latency_get = scmi_dvfs_transition_latency_get,
.add_opps_to_device = scmi_dvfs_add_opps_to_device, .device_opps_add = scmi_dvfs_device_opps_add,
.freq_set = scmi_dvfs_freq_set, .freq_set = scmi_dvfs_freq_set,
.freq_get = scmi_dvfs_freq_get, .freq_get = scmi_dvfs_freq_get,
}; };

10
include/linux/scmi_protocol.h
View File

@ -85,8 +85,8 @@ struct scmi_clk_ops {
* @level_set: sets the performance level of a domain * @level_set: sets the performance level of a domain
* @level_get: gets the performance level of a domain * @level_get: gets the performance level of a domain
* @device_domain_id: gets the scmi domain id for a given device * @device_domain_id: gets the scmi domain id for a given device
* @get_transition_latency: gets the DVFS transition latency for a given device * @transition_latency_get: gets the DVFS transition latency for a given device
* @add_opps_to_device: adds all the OPPs for a given device * @device_opps_add: adds all the OPPs for a given device
* @freq_set: sets the frequency for a given device using sustained frequency * @freq_set: sets the frequency for a given device using sustained frequency
* to sustained performance level mapping * to sustained performance level mapping
* @freq_get: gets the frequency for a given device using sustained frequency * @freq_get: gets the frequency for a given device using sustained frequency
@ -102,10 +102,10 @@ struct scmi_perf_ops {
int (*level_get)(const struct scmi_handle *handle, u32 domain, int (*level_get)(const struct scmi_handle *handle, u32 domain,
u32 *level, bool poll); u32 *level, bool poll);
int (*device_domain_id)(struct device *dev); int (*device_domain_id)(struct device *dev);
int (*get_transition_latency)(const struct scmi_handle *handle, int (*transition_latency_get)(const struct scmi_handle *handle,
struct device *dev); struct device *dev);
int (*add_opps_to_device)(const struct scmi_handle *handle, int (*device_opps_add)(const struct scmi_handle *handle,
struct device *dev); struct device *dev);
int (*freq_set)(const struct scmi_handle *handle, u32 domain, int (*freq_set)(const struct scmi_handle *handle, u32 domain,
unsigned long rate, bool poll); unsigned long rate, bool poll);
int (*freq_get)(const struct scmi_handle *handle, u32 domain, int (*freq_get)(const struct scmi_handle *handle, u32 domain,