p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

media: lirc: no need to recalculate duration 

This is code existed for when drivers would send less than the whole
buffer; no driver does this any more, so this is redundant. Drivers
should return -EINVAL if they cannot send the entire buffer.

Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
This commit is contained in:
Sean Young 2017-12-13 16:17:44 -05:00 committed by Mauro Carvalho Chehab
parent a74b2bff59
commit 7b3aa7146e
1 changed files with 1 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/media/rc/lirc_dev.c
View File

@ -347,15 +347,6 @@ static ssize_t ir_lirc_transmit_ir(struct file *file, const char __user *buf,
if (ret < 0) if (ret < 0)
goto out_kfree; goto out_kfree;
if (fh->send_mode == LIRC_MODE_SCANCODE) {
ret = n;
} else {
for (duration = i = 0; i < ret; i++)
duration += txbuf[i];
ret *= sizeof(unsigned int);
}
/* /*
* The lircd gap calculation expects the write function to * The lircd gap calculation expects the write function to
* wait for the actual IR signal to be transmitted before * wait for the actual IR signal to be transmitted before
@ -368,6 +359,7 @@ static ssize_t ir_lirc_transmit_ir(struct file *file, const char __user *buf,
schedule_timeout(usecs_to_jiffies(towait)); schedule_timeout(usecs_to_jiffies(towait));
} }
ret = n;
out_kfree: out_kfree:
kfree(txbuf); kfree(txbuf);
kfree(raw); kfree(raw);