p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

perf tools: Remove const from thread read accessors 

The namespaces and comm fields of a thread are protected by rwsem and
require write access for it.  So it ended up using a cast to remove
the const qualifier.  Let's get rid of the const then.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Suggested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Hari Bathini <hbathini@linux.vnet.ibm.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Krister Johansen <kjlx@templeofstupid.com>
Link: http://lkml.kernel.org/r/20190527061149.168640-1-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:
Namhyung Kim 2019-05-27 15:11:49 +09:00 committed by Arnaldo Carvalho de Melo
parent a0c0a4ac02
commit 7cb10a08df
3 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tools/perf/util/hist.c
View File

@ -2561,7 +2561,7 @@ int __hists__scnprintf_title(struct hists *hists, char *bf, size_t size, bool sh
char unit; char unit;
int printed; int printed;
const struct dso *dso = hists->dso_filter; const struct dso *dso = hists->dso_filter;
const struct thread *thread = hists->thread_filter; struct thread *thread = hists->thread_filter;
int socket_id = hists->socket_filter; int socket_id = hists->socket_filter;
unsigned long nr_samples = hists->stats.nr_events[PERF_RECORD_SAMPLE]; unsigned long nr_samples = hists->stats.nr_events[PERF_RECORD_SAMPLE];
u64 nr_events = hists->stats.total_period; u64 nr_events = hists->stats.total_period;

12
tools/perf/util/thread.c
View File

@ -141,13 +141,13 @@ static struct namespaces *__thread__namespaces(const struct thread *thread)
return list_first_entry(&thread->namespaces_list, struct namespaces, list); return list_first_entry(&thread->namespaces_list, struct namespaces, list);
} }
struct namespaces *thread__namespaces(const struct thread *thread) struct namespaces *thread__namespaces(struct thread *thread)
{ {
struct namespaces *ns; struct namespaces *ns;
down_read((struct rw_semaphore *)&thread->namespaces_lock); down_read(&thread->namespaces_lock);
ns = __thread__namespaces(thread); ns = __thread__namespaces(thread);
up_read((struct rw_semaphore *)&thread->namespaces_lock); up_read(&thread->namespaces_lock);
return ns; return ns;
} }
@ -271,13 +271,13 @@ static const char *__thread__comm_str(const struct thread *thread)
return comm__str(comm); return comm__str(comm);
} }
const char *thread__comm_str(const struct thread *thread) const char *thread__comm_str(struct thread *thread)
{ {
const char *str; const char *str;
down_read((struct rw_semaphore *)&thread->comm_lock); down_read(&thread->comm_lock);
str = __thread__comm_str(thread); str = __thread__comm_str(thread);
up_read((struct rw_semaphore *)&thread->comm_lock); up_read(&thread->comm_lock);
return str; return str;
} }

4
tools/perf/util/thread.h
View File

@ -76,7 +76,7 @@ static inline void thread__exited(struct thread *thread)
thread->dead = true; thread->dead = true;
} }
struct namespaces *thread__namespaces(const struct thread *thread); struct namespaces *thread__namespaces(struct thread *thread);
int thread__set_namespaces(struct thread *thread, u64 timestamp, int thread__set_namespaces(struct thread *thread, u64 timestamp,
struct namespaces_event *event); struct namespaces_event *event);
@ -93,7 +93,7 @@ int thread__set_comm_from_proc(struct thread *thread);
int thread__comm_len(struct thread *thread); int thread__comm_len(struct thread *thread);
struct comm *thread__comm(const struct thread *thread); struct comm *thread__comm(const struct thread *thread);
struct comm *thread__exec_comm(const struct thread *thread); struct comm *thread__exec_comm(const struct thread *thread);
const char *thread__comm_str(const struct thread *thread); const char *thread__comm_str(struct thread *thread);
int thread__insert_map(struct thread *thread, struct map *map); int thread__insert_map(struct thread *thread, struct map *map);
int thread__fork(struct thread *thread, struct thread *parent, u64 timestamp, bool do_maps_clone); int thread__fork(struct thread *thread, struct thread *parent, u64 timestamp, bool do_maps_clone);
size_t thread__fprintf(struct thread *thread, FILE *fp); size_t thread__fprintf(struct thread *thread, FILE *fp);