p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

gpio: janz-ttl: Be sure to clamp return value 

As we want gpio_chip .get() calls to be able to return negative
error codes and propagate to drivers, we need to go over all
drivers and make sure their return values are clamped to [0,1].
We do this by using the ret = !!(val) design pattern.

Cc: Ira W. Snyder <iws@ovro.caltech.edu>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
Linus Walleij 2015-12-21 11:03:33 +01:00
parent 4c628f3de6
commit 828240c27a
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/gpio/gpio-janz-ttl.c
View File

@ -76,7 +76,7 @@ static int ttl_get_value(struct gpio_chip *gpio, unsigned offset)
spin_lock(&mod->lock); spin_lock(&mod->lock);
ret = *shadow & (1 << offset); ret = *shadow & (1 << offset);
spin_unlock(&mod->lock); spin_unlock(&mod->lock);
return ret; return !!ret;
} }
static void ttl_set_value(struct gpio_chip *gpio, unsigned offset, int value) static void ttl_set_value(struct gpio_chip *gpio, unsigned offset, int value)