drm/edid: Don't print an error if the checksum of a CEA block is wrong
It's common to share screens within CI labs, and it's also common for KVM switches to alter the contents of the CEA block but leave the checksum outdated. So in this case, print a debug message instead of an error. References: https://bugs.freedesktop.org/show_bug.cgi?id=98228 Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: Tomi Sarvela <tomi.p.sarvela@intel.com> Cc: intel-gfx@lists.freedesktop.org Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com> Tested-by: Jari Tahvanainen <jari.tahvanainen@intel.com> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> Link: http://patchwork.freedesktop.org/patch/msgid/1481202716-31317-1-git-send-email-tomeu.vizoso@collabora.com
This commit is contained in:
parent
2776b1c190
commit
82d753567f
|
@ -1131,16 +1131,19 @@ bool drm_edid_block_valid(u8 *raw_edid, int block, bool print_bad_edid,
|
||||||
|
|
||||||
csum = drm_edid_block_checksum(raw_edid);
|
csum = drm_edid_block_checksum(raw_edid);
|
||||||
if (csum) {
|
if (csum) {
|
||||||
if (print_bad_edid) {
|
|
||||||
DRM_ERROR("EDID checksum is invalid, remainder is %d\n", csum);
|
|
||||||
}
|
|
||||||
|
|
||||||
if (edid_corrupt)
|
if (edid_corrupt)
|
||||||
*edid_corrupt = true;
|
*edid_corrupt = true;
|
||||||
|
|
||||||
/* allow CEA to slide through, switches mangle this */
|
/* allow CEA to slide through, switches mangle this */
|
||||||
if (raw_edid[0] != 0x02)
|
if (raw_edid[0] == CEA_EXT) {
|
||||||
|
DRM_DEBUG("EDID checksum is invalid, remainder is %d\n", csum);
|
||||||
|
DRM_DEBUG("Assuming a KVM switch modified the CEA block but left the original checksum\n");
|
||||||
|
} else {
|
||||||
|
if (print_bad_edid)
|
||||||
|
DRM_ERROR("EDID checksum is invalid, remainder is %d\n", csum);
|
||||||
|
|
||||||
goto bad;
|
goto bad;
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
/* per-block-type checks */
|
/* per-block-type checks */
|
||||||
|
|
Loading…
Reference in New Issue