p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

powerpc/powernv: Check sysfs size before copying 

The sysparam code currently uses the userspace supplied number of
bytes when memcpy()ing in to a local 64-byte buffer.

Limit the maximum number of bytes by the size of the buffer.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
This commit is contained in:
Joel Stanley 2014-04-24 16:55:35 +09:30 committed by Benjamin Herrenschmidt
parent b8569d2304
commit 85390378f0
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
arch/powerpc/platforms/powernv/opal-sysparam.c
View File

@ -135,6 +135,10 @@ static ssize_t sys_param_store(struct kobject *kobj,
kobj_attr); kobj_attr);
ssize_t ret; ssize_t ret;
/* MAX_PARAM_DATA_LEN is sizeof(param_data_buf) */
if (count > MAX_PARAM_DATA_LEN)
count = MAX_PARAM_DATA_LEN;
mutex_lock(&opal_sysparam_mutex); mutex_lock(&opal_sysparam_mutex);
memcpy(param_data_buf, buf, count); memcpy(param_data_buf, buf, count);
ret = opal_set_sys_param(attr->param_id, attr->param_size, ret = opal_set_sys_param(attr->param_id, attr->param_size,