p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

pkt_sched: fq: remove useless TIME_WAIT check 

TIME_WAIT sockets are not owning any skb.

ip_send_unicast_reply() and tcp_v6_send_response() both use
regular sockets.

We can safely remove a test in sch_fq and save one cache line miss,
as sk_state is far away from sk_pacing_rate.

Tested at Google for about one year.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Eric Dumazet 2015-01-28 06:06:36 -08:00 committed by David S. Miller
parent 2dbce096ca
commit 86b3bfe914
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
net/sched/sch_fq.c
View File

@ -1,7 +1,7 @@
/* /*
* net/sched/sch_fq.c Fair Queue Packet Scheduler (per flow pacing) * net/sched/sch_fq.c Fair Queue Packet Scheduler (per flow pacing)
* *
* Copyright (C) 2013 Eric Dumazet <edumazet@google.com> * Copyright (C) 2013-2015 Eric Dumazet <edumazet@google.com>
* *
* This program is free software; you can redistribute it and/or * This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License * modify it under the terms of the GNU General Public License
@ -471,7 +471,7 @@ static struct sk_buff *fq_dequeue(struct Qdisc *sch)
goto out; goto out;
rate = q->flow_max_rate; rate = q->flow_max_rate;
if (skb->sk && skb->sk->sk_state != TCP_TIME_WAIT) if (skb->sk)
rate = min(skb->sk->sk_pacing_rate, rate); rate = min(skb->sk->sk_pacing_rate, rate);
if (rate != ~0U) { if (rate != ~0U) {