p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

smsc75xx: fix smsc75xx_set_features() 

If an attempt is made to disable RX checksums, USB adapter is changed
but netdev->features is not, because smsc75xx_set_features() returns a
non zero value.

This throws errors from netdev_rx_csum_fault() :
<devname>: hw csum failure

Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Steve Glendinning <steve.glendinning@shawell.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Eric Dumazet 2018-02-20 21:42:26 -08:00 committed by David S. Miller
parent b87b6194be
commit 88e80c6267
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/net/usb/smsc75xx.c
View File

@ -954,10 +954,11 @@ static int smsc75xx_set_features(struct net_device *netdev,
/* it's racing here! */ /* it's racing here! */
ret = smsc75xx_write_reg(dev, RFE_CTL, pdata->rfe_ctl); ret = smsc75xx_write_reg(dev, RFE_CTL, pdata->rfe_ctl);
if (ret < 0) if (ret < 0) {
netdev_warn(dev->net, "Error writing RFE_CTL\n"); netdev_warn(dev->net, "Error writing RFE_CTL\n");
return ret;
return ret; }
return 0;
} }
static int smsc75xx_wait_ready(struct usbnet *dev, int in_pm) static int smsc75xx_wait_ready(struct usbnet *dev, int in_pm)