p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

test_overflow: fix an IS_ERR() vs NULL bug 

root_device_register() returns error pointers, it never returns NULL.

Fixes: ca90800a91 ("test_overflow: Add memory allocation overflow tests")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Kees Cook <keescook@chromium.org>
This commit is contained in:
Dan Carpenter 2018-06-12 15:04:33 +03:00 committed by Kees Cook
parent d54d35c501
commit 8958fd411b
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/test_overflow.c
View File

@ -367,7 +367,7 @@ static int __init test_overflow_allocation(void)
/* Create dummy device for devm_kmalloc()-family tests. */ /* Create dummy device for devm_kmalloc()-family tests. */
dev = root_device_register(device_name); dev = root_device_register(device_name);
if (!dev) { if (IS_ERR(dev)) {
pr_warn("Cannot register test device\n"); pr_warn("Cannot register test device\n");
return 1; return 1;
} }