p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

gpio: siox: Use devm_ managed gpiochip 

By using devm_gpiochip_add_data() we can get rid of the
remove() callback. As this driver doesn't use the
gpiochip data pointer we simply pass in NULL.

Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
Linus Walleij 2019-06-26 10:23:28 +02:00
parent acc141374d
commit 8b29450437
1 changed files with 1 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/gpio/gpio-siox.c
View File

@ -246,24 +246,15 @@ static int gpio_siox_probe(struct siox_device *sdevice)
girq->default_type = IRQ_TYPE_NONE; girq->default_type = IRQ_TYPE_NONE;
girq->handler = handle_level_irq; girq->handler = handle_level_irq;
ret = gpiochip_add(&ddata->gchip); ret = devm_gpiochip_add_data(dev, &ddata->gchip, NULL);
if (ret) if (ret)
dev_err(dev, "Failed to register gpio chip (%d)\n", ret); dev_err(dev, "Failed to register gpio chip (%d)\n", ret);
return ret; return ret;
} }
static int gpio_siox_remove(struct siox_device *sdevice)
{
struct gpio_siox_ddata *ddata = dev_get_drvdata(&sdevice->dev);
gpiochip_remove(&ddata->gchip);
return 0;
}
static struct siox_driver gpio_siox_driver = { static struct siox_driver gpio_siox_driver = {
.probe = gpio_siox_probe, .probe = gpio_siox_probe,
.remove = gpio_siox_remove,
.set_data = gpio_siox_set_data, .set_data = gpio_siox_set_data,
.get_data = gpio_siox_get_data, .get_data = gpio_siox_get_data,
.driver = { .driver = {