p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

iio: sx9500: Use complete() instead of complete_all() 

There is only one waiter for the completion, therefore there
is no need to use complete_all(). Let's make that clear by
using complete() instead of complete_all().

The usage pattern of the completion is:

waiter context                          waker context

sx9500_read_proximity()
  sx9500_inc_chan_users()
  sx9500_inc_data_rdy_users()
  wait_for_completion_interruptible()

                                        s9500_irq_thread_handler()
                                          complete()

  reinit_completion()

Signed-off-by: Daniel Wagner <daniel.wagner@bmw-carit.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
This commit is contained in:
Daniel Wagner 2016-08-04 15:07:10 +02:00 committed by Jonathan Cameron
parent cba4985ed5
commit 8c11e16177
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/iio/proximity/sx9500.c
View File

@ -516,7 +516,7 @@ static irqreturn_t sx9500_irq_thread_handler(int irq, void *private)
sx9500_push_events(indio_dev); sx9500_push_events(indio_dev);
if (val & SX9500_CONVDONE_IRQ) if (val & SX9500_CONVDONE_IRQ)
complete_all(&data->completion); complete(&data->completion);
out: out:
mutex_unlock(&data->mutex); mutex_unlock(&data->mutex);