p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

dmaengine: s3c24xx-dma: make phy->irq signed for error handling 

There is a bug in s3c24xx_dma_probe() where we do:

		phy->irq = platform_get_irq(pdev, i);
		if (phy->irq < 0) {

The problem is that "phy->irq" is unsigned so the error handling doesn't
work.  I have changed it to signed.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
This commit is contained in:
Dan Carpenter 2013-11-07 10:52:00 +03:00 committed by Vinod Koul
parent 4de9b3b044
commit 8f83f50229
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/dma/s3c24xx-dma.c
View File

@ -192,7 +192,7 @@ struct s3c24xx_dma_phy {
unsigned int id; unsigned int id;
bool valid; bool valid;
void __iomem *base; void __iomem *base;
unsigned int irq; int irq;
struct clk *clk; struct clk *clk;
spinlock_t lock; spinlock_t lock;
struct s3c24xx_dma_chan *serving; struct s3c24xx_dma_chan *serving;