p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fs/adfs: newdir: merge adfs_dir_read() into adfs_f_read() 

adfs_dir_read() is only called from adfs_f_read(), so merge it into
that function.  As new directories are always 2048 bytes in size,
(which we rely on elsewhere) we can consolidate some of the code.

Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
This commit is contained in:
Russell King 2019-12-09 11:10:37 +00:00 committed by Al Viro
parent 7a0e4048bf
commit 9318731bec
1 changed files with 7 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
fs/adfs/dir_f.c
View File

@ -138,20 +138,16 @@ static int adfs_f_validate(struct adfs_dir *dir)
} }
/* Read and check that a directory is valid */ /* Read and check that a directory is valid */
static int adfs_dir_read(struct super_block *sb, u32 indaddr, static int adfs_f_read(struct super_block *sb, u32 indaddr, unsigned int size,
unsigned int size, struct adfs_dir *dir) struct adfs_dir *dir)
{ {
const unsigned int blocksize_bits = sb->s_blocksize_bits; const unsigned int blocksize_bits = sb->s_blocksize_bits;
int ret; int ret;
/* if (size && size != ADFS_NEWDIR_SIZE)
* Directories which are not a multiple of 2048 bytes return -EIO;
* are considered bad v2 [3.6]
*/
if (size & 2047)
goto bad_dir;
ret = adfs_dir_read_buffers(sb, indaddr, size, dir); ret = adfs_dir_read_buffers(sb, indaddr, ADFS_NEWDIR_SIZE, dir);
if (ret) if (ret)
return ret; return ret;
@ -161,6 +157,8 @@ static int adfs_dir_read(struct super_block *sb, u32 indaddr,
if (adfs_f_validate(dir)) if (adfs_f_validate(dir))
goto bad_dir; goto bad_dir;
dir->parent_id = adfs_readval(dir->newtail->dirparent, 3);
return 0; return 0;
bad_dir: bad_dir:
@ -271,23 +269,6 @@ static int adfs_dir_find_entry(struct adfs_dir *dir, u32 indaddr)
return ret; return ret;
} }
static int adfs_f_read(struct super_block *sb, u32 indaddr, unsigned int size,
struct adfs_dir *dir)
{
int ret;
if (size != ADFS_NEWDIR_SIZE)
return -EIO;
ret = adfs_dir_read(sb, indaddr, size, dir);
if (ret)
adfs_error(sb, "unable to read directory");
else
dir->parent_id = adfs_readval(dir->newtail->dirparent, 3);
return ret;
}
static int static int
adfs_f_setpos(struct adfs_dir *dir, unsigned int fpos) adfs_f_setpos(struct adfs_dir *dir, unsigned int fpos)
{ {