p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

block: clear all of bi_opf in bio_set_op_attrs 

Since commit 87374179 ("block: add a proper block layer data direction
encoding") we only or the new op and flags into bi_opf in bio_set_op_attrs
instead of clearing the old value.  I've not seen any breakage with the
new behavior, but it seems dangerous.

Also convert it to an inline function to make the argument passing
safer.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <axboe@fb.com>
This commit is contained in:
Christoph Hellwig 2016-11-21 16:18:18 +01:00 committed by Jens Axboe
parent 5a8b187c61
commit 93c5bdf7ab
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
include/linux/blk_types.h
View File

@ -207,8 +207,11 @@ enum req_flag_bits {
((req)->cmd_flags & REQ_OP_MASK)
/* obsolete, don't use in new code */
#define bio_set_op_attrs(bio, op, op_flags) \
((bio)->bi_opf |= (op | op_flags))
static inline void bio_set_op_attrs(struct bio *bio, unsigned op,
unsigned op_flags)
{
bio->bi_opf = op | op_flags;
}
static inline bool op_is_write(unsigned int op)
{