regulator: palmas: Drop unnecessary static
Drop static on a local variable, when the variable is initialized before any use, on every possible execution path through the function. The semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @bad exists@ position p; identifier x; type T; @@ static T x@p; ... x = <+...x...+> @@ identifier x; expression e; type T; position p != bad.p; @@ -static T x@p; ... when != x when strict ?x = e; // </smpl> There is no reduction in code size in this case, but the change does reduce the size of the bss segment, containing uninitialized static data. before: text data bss dec hex filename 12882 3480 8 16370 3ff2 drivers/regulator/palmas-regulator.o after: text data bss dec hex filename 12882 3480 0 16362 3fea drivers/regulator/palmas-regulator.o Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
parent
2ea659a9ef
commit
96e4f5232c
|
@ -1491,7 +1491,7 @@ static int palmas_dt_to_pdata(struct device *dev,
|
|||
}
|
||||
|
||||
for (idx = 0; idx < ddata->max_reg; idx++) {
|
||||
static struct of_regulator_match *match;
|
||||
struct of_regulator_match *match;
|
||||
struct palmas_reg_init *rinit;
|
||||
struct device_node *np;
|
||||
|
||||
|
|
Loading…
Reference in New Issue