p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

net/smc: fix ethernet interface refcounting 

If a pnet table entry is to be added mentioning a valid ethernet
interface, but an invalid infiniband or ISM device, the dev_put()
operation for the ethernet interface is called twice, resulting
in a negative refcount for the ethernet interface, which disables
removal of such a network interface.

This patch removes one of the dev_put() calls.

Fixes: 890a2cb4a9 ("net/smc: rework pnet table")
Signed-off-by: Ursula Braun <ubraun@linux.ibm.com>
Signed-off-by: Karsten Graul <kgraul@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Ursula Braun 2019-11-06 10:49:57 +01:00 committed by David S. Miller
parent 9990a79d8f
commit 98f3375505
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
net/smc/smc_pnet.c
View File

@ -376,8 +376,6 @@ static int smc_pnet_fill_entry(struct net *net,
return 0; return 0;
error: error:
if (pnetelem->ndev)
dev_put(pnetelem->ndev);
return rc; return rc;
} }