p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

remoteproc: imx_rproc: Slightly simplify code in 'imx_rproc_probe()' 

We can return directly at the beginning of the function and save the 'err'
label.
We can also explicitly return 0 when the probe succeed.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
This commit is contained in:
Christophe JAILLET 2018-03-14 20:56:39 +01:00 committed by Bjorn Andersson
parent 96a30d7f91
commit 99a31adfb2
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/remoteproc/imx_rproc.c
View File

@ -333,10 +333,8 @@ static int imx_rproc_probe(struct platform_device *pdev)
/* set some other name then imx */ /* set some other name then imx */
rproc = rproc_alloc(dev, "imx-rproc", &imx_rproc_ops, rproc = rproc_alloc(dev, "imx-rproc", &imx_rproc_ops,
NULL, sizeof(*priv)); NULL, sizeof(*priv));
if (!rproc) { if (!rproc)
ret = -ENOMEM; return -ENOMEM;
goto err;
}
dcfg = of_device_get_match_data(dev); dcfg = of_device_get_match_data(dev);
if (!dcfg) { if (!dcfg) {
@ -381,13 +379,13 @@ static int imx_rproc_probe(struct platform_device *pdev)
goto err_put_clk; goto err_put_clk;
} }
return ret; return 0;
err_put_clk: err_put_clk:
clk_disable_unprepare(priv->clk); clk_disable_unprepare(priv->clk);
err_put_rproc: err_put_rproc:
rproc_free(rproc); rproc_free(rproc);
err:
return ret; return ret;
} }