p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[media] DVB-frontends: Deletion of unnecessary checks before the function call "release_firmware" 

GIT_AUTHOR_DATE=1416472432
The release_firmware() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
This commit is contained in:
Markus Elfring 2014-11-19 18:27:24 -03:00 committed by Mauro Carvalho Chehab
parent d442b15fb4
commit 9bc2dd7ec0
4 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/media/dvb-frontends/drx39xyj/drxj.c
View File

@ -12255,8 +12255,7 @@ static void drx39xxj_release(struct dvb_frontend *fe)
kfree(demod->my_ext_attr);
kfree(demod->my_common_attr);
kfree(demod->my_i2c_dev_addr);
if (demod->firmware)
release_firmware(demod->firmware);
release_firmware(demod->firmware);
kfree(demod);
kfree(state);
}

3
drivers/media/dvb-frontends/drxk_hard.c
View File

@ -6310,8 +6310,7 @@ static void drxk_release(struct dvb_frontend *fe)
struct drxk_state *state = fe->demodulator_priv;
dprintk(1, "\n");
if (state->fw)
release_firmware(state->fw);
release_firmware(state->fw);
kfree(state);
}

3
drivers/media/dvb-frontends/m88ds3103.c
View File

@ -687,8 +687,7 @@ static int m88ds3103_init(struct dvb_frontend *fe)
return 0;
err:
if (fw)
release_firmware(fw);
release_firmware(fw);
dev_dbg(&priv->i2c->dev, "%s: failed=%d\n", __func__, ret);
return ret;

3
drivers/media/dvb-frontends/si2168.c
View File

@ -507,8 +507,7 @@ static int si2168_init(struct dvb_frontend *fe)
return 0;
err:
if (fw)
release_firmware(fw);
release_firmware(fw);
dev_dbg(&s->client->dev, "failed=%d\n", ret);
return ret;