p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

usb: phy: tegra: Avoid use of sizeof(void) 

The PHY configuration is stored in an opaque "config" field, but when
allocating the structure, its proper size needs to be known. In the case
of UTMI, the proper structure is tegra_utmip_config of which a local
variable already exists, so we can use that to obtain the size from.

Fixes the following warning from the sparse checker:

	drivers/usb/phy/phy-tegra-usb.c:882:17: warning: expression using sizeof(void)

Fixes: 81d5dfe6d8 (usb: phy: tegra: Read UTMIP parameters from device tree)
Cc: stable@vger.kernel.org
Signed-off-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
This commit is contained in:
Thierry Reding 2014-07-21 13:37:37 +02:00 committed by Felipe Balbi
parent 36687e3056
commit 9ce9ec95fb
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/usb/phy/phy-tegra-usb.c
View File

@ -878,8 +878,8 @@ static int utmi_phy_probe(struct tegra_usb_phy *tegra_phy,
return -ENOMEM; return -ENOMEM;
} }
tegra_phy->config = devm_kzalloc(&pdev->dev, tegra_phy->config = devm_kzalloc(&pdev->dev, sizeof(*config),
sizeof(*tegra_phy->config), GFP_KERNEL); GFP_KERNEL);
if (!tegra_phy->config) { if (!tegra_phy->config) {
dev_err(&pdev->dev, dev_err(&pdev->dev,
"unable to allocate memory for USB UTMIP config\n"); "unable to allocate memory for USB UTMIP config\n");