p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

i915: use find_lock_page instead of find_lock_entry 

i915 does not want to see value entries.  Switch it to use
find_lock_page() instead, and remove the export of find_lock_entry().
Move find_lock_entry() and find_get_entry() to mm/internal.h to discourage
any future use.

Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
Cc: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Huang Ying <ying.huang@intel.com>
Cc: Hugh Dickins <hughd@google.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Matthew Auld <matthew.auld@intel.com>
Cc: William Kucharski <william.kucharski@oracle.com>
Link: https://lkml.kernel.org/r/20200910183318.20139-6-willy@infradead.org
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Matthew Wilcox (Oracle) 2020-10-13 16:51:31 -07:00 committed by Linus Torvalds
parent 8cf886463e
commit 9dfc8ff34b
4 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/gpu/drm/i915/gem/i915_gem_shmem.c
View File

@ -258,8 +258,8 @@ shmem_writeback(struct drm_i915_gem_object *obj)
for (i = 0; i < obj->base.size >> PAGE_SHIFT; i++) { for (i = 0; i < obj->base.size >> PAGE_SHIFT; i++) {
struct page *page; struct page *page;
page = find_lock_entry(mapping, i); page = find_lock_page(mapping, i);
if (!page || xa_is_value(page)) if (!page)
continue; continue;
if (!page_mapped(page) && clear_page_dirty_for_io(page)) { if (!page_mapped(page) && clear_page_dirty_for_io(page)) {

2
include/linux/pagemap.h
View File

@ -385,8 +385,6 @@ static inline struct page *find_subpage(struct page *head, pgoff_t index)
return head + (index & (thp_nr_pages(head) - 1)); return head + (index & (thp_nr_pages(head) - 1));
} }
struct page *find_get_entry(struct address_space *mapping, pgoff_t offset);
struct page *find_lock_entry(struct address_space *mapping, pgoff_t offset);
unsigned find_get_entries(struct address_space *mapping, pgoff_t start, unsigned find_get_entries(struct address_space *mapping, pgoff_t start,
unsigned int nr_entries, struct page **entries, unsigned int nr_entries, struct page **entries,
pgoff_t *indices); pgoff_t *indices);

1
mm/filemap.c
View File

@ -1726,7 +1726,6 @@ struct page *find_lock_entry(struct address_space *mapping, pgoff_t offset)
} }
return page; return page;
} }
EXPORT_SYMBOL(find_lock_entry);
/** /**
* pagecache_get_page - Find and get a reference to a page. * pagecache_get_page - Find and get a reference to a page.

3
mm/internal.h
View File

@ -65,6 +65,9 @@ static inline void ra_submit(struct file_ra_state *ra,
ra->start, ra->size, ra->async_size); ra->start, ra->size, ra->async_size);
} }
struct page *find_get_entry(struct address_space *mapping, pgoff_t index);
struct page *find_lock_entry(struct address_space *mapping, pgoff_t index);
/** /**
* page_evictable - test whether a page is evictable * page_evictable - test whether a page is evictable
* @page: the page to test * @page: the page to test