p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

blk-iolatency: deal with nr_requests == 1 

Hitting the case where blk_queue_depth() returned 1 uncovered the fact
that iolatency doesn't actually handle this case properly, it simply
doesn't scale down anybody.  For this case we should go straight into
applying the time delay, which we weren't doing.  Since we already limit
the floor at 1 request this if statement is not needed, and this allows
us to set our depth to 1 which allows us to apply the delay if needed.

Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
This commit is contained in:
Josef Bacik 2018-09-28 13:45:40 -04:00 committed by Jens Axboe
parent ff4cee0898
commit 9f60511a02
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
block/blk-iolatency.c
View File

@ -312,7 +312,7 @@ static void scale_change(struct iolatency_grp *iolat, bool up)
iolat->rq_depth.max_depth = old; iolat->rq_depth.max_depth = old;
wake_up_all(&iolat->rq_wait.wait); wake_up_all(&iolat->rq_wait.wait);
} }
} else if (old > 1) { } else {
old >>= 1; old >>= 1;
iolat->rq_depth.max_depth = max(old, 1UL); iolat->rq_depth.max_depth = max(old, 1UL);
} }