p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

net: tipc: bcast: Replace GFP_ATOMIC with GFP_KERNEL in tipc_bcast_init() 

tipc_bcast_init() is never called in atomic context.
It calls kzalloc() with GFP_ATOMIC, which is not necessary.
GFP_ATOMIC can be replaced with GFP_KERNEL.

This is found by a static analysis tool named DCNS written by myself.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Jia-Ju Bai 2018-07-27 17:31:35 +08:00 committed by David S. Miller
parent 04b9ce48ef
commit a0732548ba
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
net/tipc/bcast.c
View File

@ -512,7 +512,7 @@ int tipc_bcast_init(struct net *net)
struct tipc_bc_base *bb = NULL; struct tipc_bc_base *bb = NULL;
struct tipc_link *l = NULL; struct tipc_link *l = NULL;
bb = kzalloc(sizeof(*bb), GFP_ATOMIC); bb = kzalloc(sizeof(*bb), GFP_KERNEL);
if (!bb) if (!bb)
goto enomem; goto enomem;
tn->bcbase = bb; tn->bcbase = bb;