p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

mei: mei_cl_unlink: no need to loop over dev list 

we can call list_del_init regardless the client is
linked or not it is always properly initialized

Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Tomas Winkler 2013-09-16 23:44:45 +03:00 committed by Greg Kroah-Hartman
parent 136698e535
commit a14c44d82f
1 changed files with 4 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
drivers/misc/mei/client.c
View File

@ -318,7 +318,6 @@ int mei_cl_link(struct mei_cl *cl, int id)
int mei_cl_unlink(struct mei_cl *cl) int mei_cl_unlink(struct mei_cl *cl)
{ {
struct mei_device *dev; struct mei_device *dev;
struct mei_cl *pos, *next;
/* don't shout on error exit path */ /* don't shout on error exit path */
if (!cl) if (!cl)
@ -330,14 +329,10 @@ int mei_cl_unlink(struct mei_cl *cl)
dev = cl->dev; dev = cl->dev;
list_for_each_entry_safe(pos, next, &dev->file_list, link) { cl_dbg(dev, cl, "unlink client");
if (cl->host_client_id == pos->host_client_id) {
cl_dbg(dev, cl, "remove host client = %d, ME client = %d\n", list_del_init(&cl->link);
pos->host_client_id, pos->me_client_id);
list_del_init(&pos->link);
break;
}
}
return 0; return 0;
} }