p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

ipmi: Fix sequence number handling 

The IPMI message handler uses a message id that the lower-layer
preserved to track the sequence number of the message.  The macros
that handled these sequence numbers were somewhat broken as they
could result in sequence number truncation and they were not
doing an "and" of the proper number of bits.

I think this actually is not a problem, because the truncation
should be harmless and the improper "and" didn't hurt anything
because sequence number generation used the same improper "and"
and wouldn't generate a sequence number that would get
truncated wrong.  However, it should be fixed.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
This commit is contained in:
Corey Minyard 2016-11-14 10:11:30 -06:00
parent 9467171018
commit a24b5dd5ed
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/char/ipmi/ipmi_msghandler.c
View File

@ -158,15 +158,16 @@ struct seq_table {
* Store the information in a msgid (long) to allow us to find a * Store the information in a msgid (long) to allow us to find a
* sequence table entry from the msgid. * sequence table entry from the msgid.
*/ */
#define STORE_SEQ_IN_MSGID(seq, seqid) (((seq&0xff)<<26) | (seqid&0x3ffffff)) #define STORE_SEQ_IN_MSGID(seq, seqid) \
((((seq) & 0x3f) << 26) | ((seqid) & 0x3ffffff))
#define GET_SEQ_FROM_MSGID(msgid, seq, seqid) \ #define GET_SEQ_FROM_MSGID(msgid, seq, seqid) \
do { \ do { \
seq = ((msgid >> 26) & 0x3f); \ seq = (((msgid) >> 26) & 0x3f); \
seqid = (msgid & 0x3fffff); \ seqid = ((msgid) & 0x3ffffff); \
} while (0) } while (0)
#define NEXT_SEQID(seqid) (((seqid) + 1) & 0x3fffff) #define NEXT_SEQID(seqid) (((seqid) + 1) & 0x3ffffff)
struct ipmi_channel { struct ipmi_channel {
unsigned char medium; unsigned char medium;