p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

lpfc: do not feed jiffies as random seed from lpfc driver 

In prandom we have already reseeding mechanisms that trigger
periodically from a much better entropy source than just
feeding in jiffies through lpfc_mbx_cmpl_fcf_scan_read_fcf_rec()
[what a function name 8-)]. Therefore, just remove this.

Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
Reviewed-by: James Smart <james.smart@emulex.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
This commit is contained in:
Daniel Borkmann 2014-09-03 12:56:20 -04:00 committed by Christoph Hellwig
parent 0d4aec132d
commit a7901acc4a
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/scsi/lpfc/lpfc_hbadisc.c
View File

@ -2147,7 +2147,6 @@ lpfc_mbx_cmpl_fcf_scan_read_fcf_rec(struct lpfc_hba *phba, LPFC_MBOXQ_t *mboxq)
uint16_t fcf_index, next_fcf_index; uint16_t fcf_index, next_fcf_index;
struct lpfc_fcf_rec *fcf_rec = NULL; struct lpfc_fcf_rec *fcf_rec = NULL;
uint16_t vlan_id; uint16_t vlan_id;
uint32_t seed;
bool select_new_fcf; bool select_new_fcf;
int rc; int rc;
@ -2384,9 +2383,6 @@ lpfc_mbx_cmpl_fcf_scan_read_fcf_rec(struct lpfc_hba *phba, LPFC_MBOXQ_t *mboxq)
phba->fcf.fcf_flag |= FCF_AVAILABLE; phba->fcf.fcf_flag |= FCF_AVAILABLE;
/* Setup initial running random FCF selection count */ /* Setup initial running random FCF selection count */
phba->fcf.eligible_fcf_cnt = 1; phba->fcf.eligible_fcf_cnt = 1;
/* Seeding the random number generator for random selection */
seed = (uint32_t)(0xFFFFFFFF & jiffies);
prandom_seed(seed);
} }
spin_unlock_irq(&phba->hbalock); spin_unlock_irq(&phba->hbalock);
goto read_next_fcf; goto read_next_fcf;