p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

staging: unisys: visorbus: remove POSTCODE from my_device_create 

Replace the POSTCODEs with dev_err in my_device_create.

Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Tim Sell <timothy.sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
David Kershner 2017-04-18 16:55:19 -04:00 committed by Greg Kroah-Hartman
parent 71a0265d27
commit a8c26e4bc2
1 changed files with 9 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
drivers/staging/unisys/visorbus/visorchipset.c
View File

@ -750,31 +750,29 @@ my_device_create(struct controlvm_message *inmsg)
bus_info = visorbus_get_device_by_id(bus_no, BUS_ROOT_DEVICE, NULL); bus_info = visorbus_get_device_by_id(bus_no, BUS_ROOT_DEVICE, NULL);
if (!bus_info) { if (!bus_info) {
POSTCODE_LINUX(DEVICE_CREATE_FAILURE_PC, dev_no, bus_no, dev_err(&chipset_dev->acpi_device->dev,
DIAG_SEVERITY_ERR); "failed to get bus by id: %d\n", bus_no);
err = -ENODEV; err = -ENODEV;
goto err_respond; goto err_respond;
} }
if (bus_info->state.created == 0) { if (bus_info->state.created == 0) {
POSTCODE_LINUX(DEVICE_CREATE_FAILURE_PC, dev_no, bus_no, dev_err(&chipset_dev->acpi_device->dev,
DIAG_SEVERITY_ERR); "bus not created, id: %d\n", bus_no);
err = -EINVAL; err = -EINVAL;
goto err_respond; goto err_respond;
} }
dev_info = visorbus_get_device_by_id(bus_no, dev_no, NULL); dev_info = visorbus_get_device_by_id(bus_no, dev_no, NULL);
if (dev_info && (dev_info->state.created == 1)) { if (dev_info && (dev_info->state.created == 1)) {
POSTCODE_LINUX(DEVICE_CREATE_FAILURE_PC, dev_no, bus_no, dev_err(&chipset_dev->acpi_device->dev,
DIAG_SEVERITY_ERR); "failed to get bus by id: %d/%d\n", bus_no, dev_no);
err = -EEXIST; err = -EEXIST;
goto err_respond; goto err_respond;
} }
dev_info = kzalloc(sizeof(*dev_info), GFP_KERNEL); dev_info = kzalloc(sizeof(*dev_info), GFP_KERNEL);
if (!dev_info) { if (!dev_info) {
POSTCODE_LINUX(DEVICE_CREATE_FAILURE_PC, dev_no, bus_no,
DIAG_SEVERITY_ERR);
err = -ENOMEM; err = -ENOMEM;
goto err_respond; goto err_respond;
} }
@ -786,9 +784,6 @@ my_device_create(struct controlvm_message *inmsg)
/* not sure where the best place to set the 'parent' */ /* not sure where the best place to set the 'parent' */
dev_info->device.parent = &bus_info->device; dev_info->device.parent = &bus_info->device;
POSTCODE_LINUX(DEVICE_CREATE_ENTRY_PC, dev_no, bus_no,
DIAG_SEVERITY_PRINT);
visorchannel = visorchannel =
visorchannel_create_with_lock(cmd->create_device.channel_addr, visorchannel_create_with_lock(cmd->create_device.channel_addr,
cmd->create_device.channel_bytes, cmd->create_device.channel_bytes,
@ -796,8 +791,9 @@ my_device_create(struct controlvm_message *inmsg)
cmd->create_device.data_type_uuid); cmd->create_device.data_type_uuid);
if (!visorchannel) { if (!visorchannel) {
POSTCODE_LINUX(DEVICE_CREATE_FAILURE_PC, dev_no, bus_no, dev_err(&chipset_dev->acpi_device->dev,
DIAG_SEVERITY_ERR); "failed to create visorchannel: %d/%d\n",
bus_no, dev_no);
err = -ENOMEM; err = -ENOMEM;
goto err_free_dev_info; goto err_free_dev_info;
} }
@ -826,8 +822,6 @@ my_device_create(struct controlvm_message *inmsg)
if (err) if (err)
goto err_destroy_visorchannel; goto err_destroy_visorchannel;
POSTCODE_LINUX(DEVICE_CREATE_EXIT_PC, dev_no, bus_no,
DIAG_SEVERITY_PRINT);
return 0; return 0;
err_destroy_visorchannel: err_destroy_visorchannel: