p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

net: phy: fixed-phy: Make the error path simpler 

When platform_device_register_simple() fails we can return
the error immediately instead of jumping to the 'err_pdev'
label.

This makes the error path a bit simpler.

Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Fabio Estevam 2018-06-23 21:28:22 -03:00 committed by David S. Miller
parent dd55c4ea9e
commit b0c1638f26
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/net/phy/fixed_phy.c
View File

@ -259,10 +259,8 @@ static int __init fixed_mdio_bus_init(void)
int ret; int ret;
pdev = platform_device_register_simple("Fixed MDIO bus", 0, NULL, 0); pdev = platform_device_register_simple("Fixed MDIO bus", 0, NULL, 0);
if (IS_ERR(pdev)) { if (IS_ERR(pdev))
ret = PTR_ERR(pdev); return PTR_ERR(pdev);
goto err_pdev;
}
fmb->mii_bus = mdiobus_alloc(); fmb->mii_bus = mdiobus_alloc();
if (fmb->mii_bus == NULL) { if (fmb->mii_bus == NULL) {
@ -287,7 +285,6 @@ static int __init fixed_mdio_bus_init(void)
mdiobus_free(fmb->mii_bus); mdiobus_free(fmb->mii_bus);
err_mdiobus_reg: err_mdiobus_reg:
platform_device_unregister(pdev); platform_device_unregister(pdev);
err_pdev:
return ret; return ret;
} }
module_init(fixed_mdio_bus_init); module_init(fixed_mdio_bus_init);