p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

mtd: nand: add new enum for storing ECC algorithm 

Our nand_ecc_modes_t is already a bit abused by value NAND_ECC_SOFT_BCH.
This enum should store ECC mode only and putting algorithm details there
is a bad idea. It would result in too many values impossible to support
in a sane way.

To solve this problem let's add a new enum. We'll have to modify all
drivers to set it properly but once it's done it'll be possible to drop
NAND_ECC_SOFT_BCH. That will result in a cleaner design and more
possibilities like setting ECC algorithm for hardware ECC mode.

Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
This commit is contained in:
Rafał Miłecki 2016-03-23 11:19:00 +01:00 committed by Boris Brezillon
parent 8de53481b4
commit b0fcd8ab7b
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
include/linux/mtd/nand.h
View File

@ -119,6 +119,12 @@ typedef enum {
NAND_ECC_SOFT_BCH, NAND_ECC_SOFT_BCH,
} nand_ecc_modes_t; } nand_ecc_modes_t;
enum nand_ecc_algo {
NAND_ECC_UNKNOWN,
NAND_ECC_HAMMING,
NAND_ECC_BCH,
};
/* /*
* Constants for Hardware ECC * Constants for Hardware ECC
*/ */
@ -458,6 +464,7 @@ struct nand_hw_control {
/** /**
* struct nand_ecc_ctrl - Control structure for ECC * struct nand_ecc_ctrl - Control structure for ECC
* @mode: ECC mode * @mode: ECC mode
* @algo: ECC algorithm
* @steps: number of ECC steps per page * @steps: number of ECC steps per page
* @size: data bytes per ECC step * @size: data bytes per ECC step
* @bytes: ECC bytes per step * @bytes: ECC bytes per step
@ -508,6 +515,7 @@ struct nand_hw_control {
*/ */
struct nand_ecc_ctrl { struct nand_ecc_ctrl {
nand_ecc_modes_t mode; nand_ecc_modes_t mode;
enum nand_ecc_algo algo;
int steps; int steps;
int size; int size;
int bytes; int bytes;