p71924506
/
linux_old1
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

objtool: Make BP scratch register warning more robust 

If func is NULL, a seg fault can result.

This is a theoretical issue which was found by Coverity, ID: 1492002
("Dereference after null check").

Fixes: c705cecc84 ("objtool: Track original function across branches")
Reported-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Link: https://lkml.kernel.org/r/afc628693a37acd287e843bcc5c0430263d93c74.1585761021.git.jpoimboe@redhat.com
This commit is contained in:
Josh Poimboeuf 2020-04-01 13:23:29 -05:00 committed by Borislav Petkov
parent b401efc120
commit b296695298
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tools/objtool/check.c
View File

@ -2005,8 +2005,8 @@ static int validate_return(struct symbol *func, struct instruction *insn, struct
} }
if (state->bp_scratch) { if (state->bp_scratch) {
WARN("%s uses BP as a scratch register", WARN_FUNC("BP used as a scratch register",
func->name); insn->sec, insn->offset);
return 1; return 1;
} }